Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: golangci-lint yamllint #19013

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: golangci-lint yamllint #19013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/.golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ issues:
# exclude ineffassing linter for generated files for conversion
- path: conversion\.go
linters: [ineffassign]
- text: "S1000" # TODO: Fix me
- text: "S1000" # TODO: Fix me
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to add the "ok-to-test" label, so it was NOT detected in previous PR #18973

Can we enforce the "ok-to-test" label before merging any PR technically?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this we need to enable tide prow plugin and delegate the merging of pr's to tide so we no longer do it manually. Usually the tide criteria is combination of approved and lgtm labels I think but we could probably require ok-to-test as well.

I discussed enabling tide with @serathius in Salt Lake City KubeCon but I have not had bandwidth to plan the change yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. The immediate solution that I can think of is to fail the Approve GitHub Workflows if ok-to-test label isn't present. Accordingly it breaks the merge-when-workflow-green rule.

linters:
- gosimple
exclude-files:
Expand Down
Loading