Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse grpcOverheadBytes calculation by creating a function for that #18991

Merged
merged 1 commit into from
Dec 2, 2024

Reuse grpcOverheadBytes calculation by creating a function for that

c77ea65
Select commit
Loading
Failed to load commit list.
Merged

Reuse grpcOverheadBytes calculation by creating a function for that #18991

Reuse grpcOverheadBytes calculation by creating a function for that
c77ea65
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 2, 2024 in 1s

68.74% (+0.21%) compared to 6fa7342

View this Pull Request on Codecov

68.74% (+0.21%) compared to 6fa7342

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (6fa7342) to head (c77ea65).

Additional details and impacted files
Files with missing lines Coverage Δ
server/config/config.go 80.23% <100.00%> (+0.47%) ⬆️
server/etcdserver/api/v3rpc/grpc.go 100.00% <100.00%> (ø)
server/etcdserver/api/v3rpc/watch.go 84.06% <100.00%> (+1.25%) ⬆️

... and 30 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18991      +/-   ##
==========================================
+ Coverage   68.53%   68.74%   +0.21%     
==========================================
  Files         420      420              
  Lines       35619    35621       +2     
==========================================
+ Hits        24410    24489      +79     
+ Misses       9777     9702      -75     
+ Partials     1432     1430       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa7342...c77ea65. Read the comment docs.