Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/faucet: update Twitter auth/API changes to v1.1 + v2 #323

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

meowsbits
Copy link
Member

6ada9f0

This adds support for v1.1 and v2 in Twitter API.

See ethereum/go-ethereum#22107

Date: 2021-02-23 05:53:57-06:00
Signed-off-by: meows b5c6@protonmail.com

This adds supporf for v1.1 in Twitter API.

Date: 2021-02-23 05:53:57-06:00
Signed-off-by: meows <b5c6@protonmail.com>
Copy link
Member

@ziogaschr ziogaschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also tested the deployed version and it works nice.

Only question is if we can/want to drop support for Twitter v1 API.

@meowsbits
Copy link
Member Author

Yea, roger that. Definitely a valid question. I haven't looked at the current state of Twitter's API; all I know is that I need -twitter.token=xyx for the thing to work 😹

@meowsbits meowsbits merged commit a7e6418 into master Mar 3, 2021
@meowsbits meowsbits deleted the faucet-update-twitter branch March 3, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants