Fix and update Besu genesis config #72
Conversation
custom_config_data/besu.json
Outdated
| @@ -14,7 +14,14 @@ | |||
| "preMergeForkBlock": 0, | |||
| "terminalTotalDifficulty": 0, | |||
| "shanghaiTime": 1694884704, | |||
| "ethash": {} | |||
| "ethash": {}, | |||
| "cancunTime": 2000000000, | |||
There was a problem hiding this comment.
The repo says Cancun TBD. Was this meant to be here?
There was a problem hiding this comment.
right not required to be here
|
It would also be good to update the timestamp field at the end of our genesis file to match what @barnabasbusa is proposing in his PR just to make sure we don't revert his changes in case his PR gets merged before this one. |
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
There should no risk of overriding, git should sort out it. @barnabasbusa could you review this? the main fix is that there was a misplaced |
|
yes plan to adjust my PR to match this syntax too. Apologies for the delay, will fix it tomorrow. cc: @parithosh |
| @@ -13,8 +13,14 @@ | |||
| "londonBlock": 0, | |||
| "preMergeForkBlock": 0, | |||
There was a problem hiding this comment.
Think this could be changed to match the geth genesis.json (although neither are used AFAIK)
| "preMergeForkBlock": 0, | |
| "mergeNetsplitBlock": 0, |
|
LGTM thanks @parithosh |
|
closing since these changes are integrated in #73 |
No description provided.