-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: create new genesis for holesky #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -12,40 +12,18 @@ This is _work in progress_. The final config will be shared prior to launch date | |||
* Status: _Planned_ ([#3](https://github.com/eth-clients/holesky/issues/3)) | |||
* Flag: `--holesky` | |||
* Flavor: Permissionless (Proof-of-Stake), _to replace Goerli_ | |||
* Launch Date: **Sept/15, 2023, 14:00 UTC** | |||
* Epoch time: 1694786400 | |||
* Launch Date: **Sept/28, 2023, 12:00 UTC** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This time suits the Australians & Kiwis a lot better than 14:00UTC. And Thursday is better than Friday as it gives a bit of a buffer to fix things before the weekend 👍
# Sep-28-2023 11:55:00 +UTC | ||
# This is an invalid valid and should be updated when you create the genesis | ||
MIN_GENESIS_TIME: 1695902100 | ||
GENESIS_FORK_VERSION: 0x01017000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱😱😱
then we will have to update deposit-cli for it.
@barnabasbusa
Is there also a new genesis_validators_root
?
/cc @CarlBeek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The genesis_validators_root
is 0x9143aa7c615a7f7115e2b6aac319c03529df8242ae705fba9df39b79c59fa8b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- Prysm is no longer complaining about missing genesis block and appears ready to launch holesky with the configs from this PR.
can we merge and start releasing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to incorporate these besu config issues first #72.
Couple of questions I want to clarify, maybe I missed some discussion about this:
-
The new genesis epoch time is 1695902400 but the EL genesis timestamp is 1695902100 (5 mins before). Just wondering why we need that 5 minutes?
-
Why can't we start with shanghai/capella at genesis?
Yup, waiting on Barnabas to merge in changes from #72 , context: #72 (comment)
|
Can any other EL teams confirm this is the ForkId for Holesky at genesis?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yes i can confim the same 🙂 |
* Update holesky config with new genesis. See eth-clients/holesky#73 * Update bootnodes * Update bootnodes * Use latest commit --------- Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
No description provided.