Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Champion wanted: BLAKE2b precompile #64

Closed
bmann opened this issue Apr 26, 2019 · 25 comments
Closed

Champion wanted: BLAKE2b precompile #64

bmann opened this issue Apr 26, 2019 · 25 comments
Labels
help wanted Extra attention is needed
Milestone
Istanbul: Hard de...

Comments

@bmann
Copy link
Contributor

bmann commented Apr 26, 2019

From ACD 60, looking for a champion for Blake2b precompile
@bmann bmann added help wanted Extra attention is needed 152 BLAKE2b Precompile labels Apr 26, 2019
@bmann
Copy link
Contributor Author

bmann commented Apr 26, 2019

@Souptacular is going to talk to @zooko about participating in this

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to it.

@lrettig
Copy link
Contributor

lrettig commented May 8, 2019

I'd be curious to hear from a professional how long this might take, how much work it might be, and what sort of budget might be needed. Happy to reach out to a few folks.

@bmann
Copy link
Contributor Author

bmann commented May 8, 2019

It’s going to be work from now until October keeping on top of shepherding this forward. Call that 10 hours per week.

Plus writing code, test cases, speed tests, and assisting different clients in implementation.

And could be done as a precompile or as speeding up VM implementations. Speeding up VM implementations / adjusting gas costs is a bigger chunk of work but has larger pay off.

In either case, call it one full time technical human plus average 10 hours per week on communications.

For 4 - 5 months. So, $12.5K per month, $62.5K

Yes, this might take less than full time, so call this the upper bound.

@lrettig
Copy link
Contributor

lrettig commented May 8, 2019

Thanks Boris, this is helpful and seems reasonable. Very grateful to Gitcoin for initial funding here - we are now 0.5% of the way towards the goal :)

@bmann bmann mentioned this issue May 10, 2019
Closed
@gitcoinbot
Copy link

💰 A crowdfund contribution worth 500.00000 DAI (500.0 USD @ $1.0/DAI) has been attached to this funded issue from @alchemydc.💰

Want to chip in also? Add your own contribution here.

2 similar comments
@gitcoinbot
Copy link

💰 A crowdfund contribution worth 500.00000 DAI (500.0 USD @ $1.0/DAI) has been attached to this funded issue from @alchemydc.💰

Want to chip in also? Add your own contribution here.

@gitcoinbot
Copy link

💰 A crowdfund contribution worth 500.00000 DAI (500.0 USD @ $1.0/DAI) has been attached to this funded issue from @alchemydc.💰

Want to chip in also? Add your own contribution here.

@gitcoinbot
Copy link

💰 A crowdfund contribution worth 3500.00000 DAI (3500.0 USD @ $1.0/DAI) has been attached to this funded issue from @alchemydc.💰

Want to chip in also? Add your own contribution here.

@Jwdev-wr
Copy link

I can do it. I'd need a week to get caught up to speed.

@gitcoinbot
Copy link

gitcoinbot commented May 22, 2019 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 week ago.
Please review their action plans below:

1) whiterabot17 has applied to start work (Funders only: approve worker | reject worker).

Step 1. Review criteria
Step 2. Communicate with developers on project about requirements.
Step 3. Review similar hash algorithm precompile code
Step 4. Code/Test
Step 5. Repeat steps 1-4.
2) madeoftin has been approved to start work.

The due date for Istanbul was last week so I reformatted and submitted the EIP. ethereum/EIPs#2024
Carterpy has also joined me on development.

I can do the majority of the legwork in shepherding the EIP through the EIP process as well as be the point of contact for developers and the community.

The next steps are too:

  • Re-implement the existing code
  • Respond to the CoreDev feedback on design choices
  • Finalize the specification
  • Bench-marking gas costs
  • Second Client implementation
  • Testing

I will continue to keep this moving forward until this EIP makes it into a Hardfork. There is still a chance it can make it into Istanbul as there is two months before the soft-deadline for client implementations.
3) srcoughlin has applied to start work (Funders only: approve worker | reject worker).

I've followed the discussion on this in core devs meeting #62 and think I can champion this along. It's going to need detailed performance metrics as the recently optimized EVM implementation already reduces the gas savings potential over when EIP 152 was originally created. This may also require consideration of heterogeneous computing optimizations.
This project can also act as a template for gas cost estimations and precompile savings estimations for other cryptographic hash functions.
4) mhluongo has applied to start work (Funders only: approve worker | reject worker).

We're working through the F precompile EIP (ethereum/EIPs#2129) as well as the get implementation (keep-network/go-ethereum#4)
5) prorokeskobar has applied to start work (Funders only: approve worker | reject worker).

Provide an action plan and any initial questions you have for this ticket.

Learn more on the Gitcoin Issue Details page.

@mkosowsk
Copy link

Is this still open @bmann @ceresstation?

I would love to throw my hat in the ring, I think I could write up an Action Plan that is quite compelling and deliver on it as well ☺️

@Jwdev-wr
Copy link

@mkosowsk Fill out the gitcoin form

@MadeofTin
Copy link

MadeofTin commented May 23, 2019 •
edited
Loading

@mkosowsk Me and @carterpy have been working on this. Are you interested in Coding for it? The next step is working on reference implementations.

@MadeofTin
Copy link

MadeofTin commented May 23, 2019 •
edited
Loading

@WhiteRaBot17 would be good to coordinate as well. Where is a good place to reach out?

Here is the current EIP proposal ethereum/EIPs#2024

There is a lot of good information in the references sections, as well has a handful of questions from the Coredevs to respond too. That is a good place to start catching up.

@spm32
Copy link

spm32 commented May 23, 2019

Glad to see you all coordinating here. @MadeofTin @mkosowsk @carterpy @WhiteRaBot17 if you're all okay with working together on this and splitting the bounty we're happy to support that.

@mkosowsk
Copy link

@MadeofTin thanks for the warm welcome :)

At this time, I think I will be coding on a different project(s) but let's keep in touch!

I will be watching this one closely :)

@MadeofTin
Copy link

No problem @mkosowsk :)

@WhiteRaBot17 let me know how best to reach you. I left a message on Gitter for you

@Jwdev-wr
Copy link

@MadeofTin @ceresstation I'd be happy to collaborate with others to push this through. Contacting @MadeofTin on gitter now.

@gitcoinbot
Copy link

💰 A crowdfund contribution worth 1.89000 ETH (499.56 USD @ $264.32/ETH) has been attached to this funded issue from @virgil.💰

Want to chip in also? Add your own contribution here.

@gitcoinbot
Copy link

💰 A crowdfund contribution worth 17.00000 ETH (4544.78 USD @ $267.34/ETH) has been attached to this funded issue from @virgil.💰

Want to chip in also? Add your own contribution here.

@mhluongo
Copy link

mhluongo commented Jun 18, 2019 •
edited
Loading

Folks, @pdyraga and I (with support from the Keep team) can champion this. We're in touch with @MadeofTin as well as @str4d and @zookozcash on the Zcash side. We're focused on an updated F EIP and geth implementation, first, then implementing @MadeofTin 's open EIP that's specific to blake2b.

There are some open questions around the interface in the latter, and we know an F precompile will suffice for most use cases- thus the strategy.

@pdyraga pdyraga mentioned this issue Jul 1, 2019
Merged
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 300.0 DAI (300.0 USD @ $1.0/DAI) has been submitted by:

  1. @madeoftin

@ceresstation please take a look at the submitted work:

@gitcoinbot
Copy link

Ethereum Pro ⚡️ A *Ethereum Pro* Kudos has been sent to @MadeofTin for this issue from @ceresstation. ⚡️

Nice work @MadeofTin!
To redeem your Kudos, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Kudos' from dropdown menu in the top right, or check your email for a link to the Kudos redemption page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 300.0 DAI (300.0 USD @ $1.0/DAI) (plus a crowdfund of 18.89 ETH, 5000.0 DAI worth 8518.0324704252 USD) attached to this issue has been approved & issued to @MadeofTin.

Thanks to @virgil, @virgil, @virgil, @alchemydc, @alchemydc, @alchemydc, @alchemydc, @alchemydc, @alchemydc, @alchemydc, @alchemydc, @alchemydc, @alchemydc, @alchemydc, @alchemydc, @alchemydc for their crowdfunded contributions to this bounty.

@poojaranjan poojaranjan mentioned this issue May 25, 2021
Closed
@poojaranjan poojaranjan mentioned this issue Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
Istanbul Hard Fork
Status: Done
Milestone
Istanbul: Hard deadline to accept pro...
Development

No branches or pull requests
9 participants
@bmann @mhluongo @MadeofTin @lrettig @mkosowsk @timbeiko @spm32 @gitcoinbot @Jwdev-wr