Generalize EIP-152 to other BLAKE2 variants #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "BLAKE2b" when specifically referring to the 12-round 64-bit variant.
ilanolkies
pushed a commit
to ilanolkies/EIPs
that referenced
this pull request
Nov 12, 2019
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
MadeofTin
pushed a commit
to MadeofTin/EIPs
that referenced
this pull request
Nov 13, 2019
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After feedback from the last AllCoreDevs call, I've adjusted the EIP to more accurately distinguish between the 64-bit BLAKE2 family of hash functions and functionality specific to BLAKE2b, the 12-round 64-bit BLAKE2 variant.
Note that I wasn't easily able to follow the suggestion to include direct
SIGMAandIVdefinitions -- as many client implementations might have different definitions due to library and language-specific optimizations, theSIGMAandIVdefinitions don't further specify the EIP over the provided test cases.As there hasn't been much activity on Gitter from implementors around the inclusion of an
m_lenparameter and it's late in the game to substantially change precompile functionality, I've left the change out due to lack of consensus.