Skip to content

Schedule and Details for the Holocene Upgrade Across Superchains #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

krofax
Copy link
Collaborator

@krofax krofax commented Dec 4, 2024

Description

Tests

Additional context

Metadata

@krofax krofax requested a review from a team as a code owner December 4, 2024 17:35
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 4779c38
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/675092f32a264f0008d56d06
😎 Deploy Preview https://deploy-preview-1161--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Dec 4, 2024

📝 Walkthrough

Walkthrough

The document titled "Preparing for Holocene Breaking Changes" has been revised to improve clarity and structure regarding the Holocene upgrade. Key modifications include the reordering of information within a Callout component, specifically highlighting the activation dates for the Unichain Sepolia, which has been moved to a new line. The document now outlines three main components of the Holocene upgrade: Holocene block derivation, EIP-1559 configurability, and MIPS contract upgrades, each accompanied by brief descriptions.

The section aimed at chain operators has been expanded, providing detailed instructions on upgrading nodes and contracts. It emphasizes the necessity of updating the SystemConfig to the latest version for EIP-1559 configurability, including updated addresses for both Sepolia and Mainnet. For fault-proof enabled chains, it specifies the need to upgrade the op-program version and the MIPS contract, as well as the deployment of FaultDisputeGame and PermissionedDisputeGame contracts for each chain.

Clarifications have also been made for node operators regarding the steps to upgrade to the latest releases of op-node and op-geth, along with guidance on configuring the Holocene activation date. A warning is included for those involved in hardfork activation inheritance behavior, indicating no action is required post-upgrade.

Possibly related PRs

Suggested labels

do-not-merge

Suggested reviewers

  • sbvegan
  • cpengilly

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
pages/builders/notices/holocene-changes.mdx (3)

16-17: Standardize date format across all activation timestamps

The date formats are inconsistent across different entries. Consider standardizing to a single format, such as "DDD DD MMM YYYY at HH:mm:ss UTC" for all dates.

Apply this formatting consistently:

- The Holocene upgrade for the Unichain Sepolia will be activated at **Wed Dec 18 at 22:00:00 UTC** (`1734559200`).
+ The Holocene upgrade for the Unichain Sepolia will be activated at **Wed 18 Dec 2023 at 22:00:00 UTC** (`1734559200`).

Line range hint 1-24: Capitalize proper noun "Safe" in technical context

The term "Safe" refers to the multi-sig wallet product and should be capitalized when used in this context.

- Safe multi-sig input bundle generation
+ Safe Multi-Sig input bundle generation

Line range hint 25-50: Add version information to contract references

For better clarity and future reference, consider adding version numbers when mentioning contract upgrades.

- Chain operators must upgrade their chain's `SystemConfig`
+ Chain operators must upgrade their chain's `SystemConfig` contract from v1.7.x to v1.8.0-rc.2
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0a6fb24 and 4779c38.

📒 Files selected for processing (1)
  • pages/builders/notices/holocene-changes.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/notices/holocene-changes.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "

@krofax krofax merged commit 7a05867 into main Dec 5, 2024
8 of 9 checks passed
@krofax krofax deleted the unichain-update branch December 5, 2024 01:12
This was referenced Feb 6, 2025
@coderabbitai coderabbitai bot mentioned this pull request Feb 14, 2025
@coderabbitai coderabbitai bot mentioned this pull request Mar 3, 2025
@coderabbitai coderabbitai bot mentioned this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants