Skip to content

adding op-contracts/v1.8.0 #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025
Merged

adding op-contracts/v1.8.0 #1444

merged 4 commits into from
Mar 4, 2025

Conversation

sbvegan
Copy link
Collaborator

@sbvegan sbvegan commented Mar 4, 2025

No description provided.

@sbvegan sbvegan requested a review from a team as a code owner March 4, 2025 17:40
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit a2a64a7
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67c73e26687a790008a3f25a
😎 Deploy Preview https://deploy-preview-1444--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Mar 4, 2025

Warning

Rate limit exceeded

@sbvegan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 21a19dd and a2a64a7.

📒 Files selected for processing (1)
  • pages/stack/smart-contracts.mdx (1 hunks)
📝 Walkthrough

Walkthrough

This pull request introduces a new section in the pages/stack/smart-contracts.mdx file for the op-contracts/v1.8.0 version, which details its relevance to Layer 1 contracts as part of the Holocene network upgrade. The section includes links to the official release and governance post, along with a changelog that highlights newly added contracts: MIPS, SystemConfig, FaultDisputeGame, and PermissionedDisputeGame, including their version numbers. Additionally, it lists contracts that have not changed, providing their current versions and links to their locations in the repository.

Possibly related PRs

  • Update smart-contracts.mdx to fix typo in change log #1017: The changes in the main PR are related to the same contracts and their versioning as those in the retrieved PR, specifically regarding SystemConfig, FaultDisputeGame, and PermissionedDisputeGame.
  • Smart contract overview update #808: The changes in the main PR regarding the new section and changelog for smart contracts are directly related to the updates made in the retrieved PR, which also focuses on enhancing the smart contract documentation and includes a changelog.
  • contracts: update standard version to v1.6.0, CGT to v2.0.0-beta.3 #895: The changes in the main PR regarding the new section for op-contracts/v1.8.0 and the updates to the changelog are related to the modifications in the retrieved PR that also updates the version information for contracts in the same documentation file, specifically pages/stack/smart-contracts.mdx.

Suggested labels

do-not-merge

Suggested reviewers

  • bradleycamacho
  • OPMattie

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
pages/stack/smart-contracts.mdx (1)

1-5: 🛠️ Refactor suggestion

Missing required frontmatter metadata.
The frontmatter currently provides only the title, lang, and description. To comply with the documentation guidelines for regular pages, please include the additional required fields:

  • topic (non-empty)
  • personas (non-empty array)
  • categories (non-empty array)
  • content_type (a valid type)

This can be fixed by running the suggested command:

pnpm metadata-batch-cli:dry "pages/stack/smart-contracts.mdx"
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42f0336 and 4f64521.

📒 Files selected for processing (1)
  • pages/stack/smart-contracts.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. You can fix this by running:
    pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
    Review the changes, then run without :dry to apply them.'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/stack/smart-contracts.mdx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (1)
pages/stack/smart-contracts.mdx (1)

36-42: New op-contracts/v1.8.0 section added.
The new section clearly outlines the release details for op-contracts/v1.8.0 as part of the Holocene network upgrade. The heading and description are concise and informative. Please verify that the version and release description accurately reflect the intended changes relative to previous versions.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
pages/notices/pectra-changes.mdx (2)

20-30: Tone and Style Improvement: Avoid Personal Pronouns.
Several sections (e.g., “We will release new versions…”) use personal pronouns. Per our guidelines, consider revising these statements into a direct, imperative tone or using proper nouns to enhance clarity and consistency in communal documentation.

🧰 Tools
🪛 LanguageTool

[style] ~25-~25: Consider using a more formal alternative.
Context: ...ncludes these features. We will provide more information as engineering work wraps up. We are tr...

(MORE_INFO)


[uncategorized] ~25-~25: You might be missing the article “the” here.
Context: ...oming Isthmus hardfork will contain all Prague features, you can track our progress in...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~25-~25: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ue features, you can track our progress in this [project board](https://github.com...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)


56-57: Minor Formatting Correction: Insert Space After Period.
At line 56, the sentence reads:
...the respective releases before the activation dates.These following steps...
A space is missing after the period. Please update it to:
...the respective releases before the activation dates. These following steps...

- before the activation dates.These following steps
+ before the activation dates. These following steps
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e83300 and 21a19dd.

📒 Files selected for processing (1)
  • pages/notices/pectra-changes.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. You can fix this by running:
    pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
    Review the changes, then run without :dry to apply them.'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/notices/pectra-changes.mdx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (2)
pages/notices/pectra-changes.mdx (2)

1-16: MetaData Validation: All required frontmatter fields are present.
The YAML metadata includes the fields title, description, lang, content_type, topic, personas, and categories with non-empty values, ensuring compliance with the required metadata for regular pages.


64-66: Update Confirmation: op-reth Release Version.
The list now correctly updates the op-reth release to v1.2.0 with the note that it “also includes L1 Pectra support.” This update appears correct. Ensure that any upstream documentation or references to op-reth reflect this change.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~64-~64: This looks wrong. Consider replacing it.
Context: ...t release. * op-node at v1.11.1 * op-geth at [v1.101500.0](https://github.com/et...

(AI_EN_LECTOR_REPLACEMENT_SPACE)

@sbvegan sbvegan merged commit cad49b1 into main Mar 4, 2025
8 checks passed
@sbvegan sbvegan deleted the sb/holocene-contract-release branch March 4, 2025 19:10
This was referenced Mar 6, 2025
@coderabbitai coderabbitai bot mentioned this pull request Mar 21, 2025
@coderabbitai coderabbitai bot mentioned this pull request Apr 10, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants