-
Notifications
You must be signed in to change notification settings - Fork 264
adding op-contracts/v1.8.0 #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Warning Rate limit exceeded@sbvegan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 50 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request introduces a new section in the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
pages/stack/smart-contracts.mdx (1)
1-5
: 🛠️ Refactor suggestionMissing required frontmatter metadata.
The frontmatter currently provides only the title, lang, and description. To comply with the documentation guidelines for regular pages, please include the additional required fields:
- topic (non-empty)
- personas (non-empty array)
- categories (non-empty array)
- content_type (a valid type)
This can be fixed by running the suggested command:
pnpm metadata-batch-cli:dry "pages/stack/smart-contracts.mdx"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/stack/smart-contracts.mdx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. You can fix this by running:Review the changes, then run without :dry to apply them.'pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/stack/smart-contracts.mdx
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (1)
pages/stack/smart-contracts.mdx (1)
36-42
: New op-contracts/v1.8.0 section added.
The new section clearly outlines the release details for op-contracts/v1.8.0 as part of the Holocene network upgrade. The heading and description are concise and informative. Please verify that the version and release description accurately reflect the intended changes relative to previous versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pages/notices/pectra-changes.mdx (2)
20-30
: Tone and Style Improvement: Avoid Personal Pronouns.
Several sections (e.g., “We will release new versions…”) use personal pronouns. Per our guidelines, consider revising these statements into a direct, imperative tone or using proper nouns to enhance clarity and consistency in communal documentation.🧰 Tools
🪛 LanguageTool
[style] ~25-~25: Consider using a more formal alternative.
Context: ...ncludes these features. We will provide more information as engineering work wraps up. We are tr...(MORE_INFO)
[uncategorized] ~25-~25: You might be missing the article “the” here.
Context: ...oming Isthmus hardfork will contain all Prague features, you can track our progress in...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~25-~25: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ue features, you can track our progress in this [project board](https://github.com...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
56-57
: Minor Formatting Correction: Insert Space After Period.
At line 56, the sentence reads:
...the respective releases before the activation dates.These following steps...
A space is missing after the period. Please update it to:
...the respective releases before the activation dates. These following steps...
- before the activation dates.These following steps + before the activation dates. These following steps
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/notices/pectra-changes.mdx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. You can fix this by running:Review the changes, then run without :dry to apply them.'pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/pectra-changes.mdx
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (2)
pages/notices/pectra-changes.mdx (2)
1-16
: MetaData Validation: All required frontmatter fields are present.
The YAML metadata includes the fieldstitle
,description
,lang
,content_type
,topic
,personas
, andcategories
with non-empty values, ensuring compliance with the required metadata for regular pages.
64-66
: Update Confirmation: op-reth Release Version.
The list now correctly updates the op-reth release tov1.2.0
with the note that it “also includes L1 Pectra support.” This update appears correct. Ensure that any upstream documentation or references to op-reth reflect this change.🧰 Tools
🪛 LanguageTool
[uncategorized] ~64-~64: This looks wrong. Consider replacing it.
Context: ...t release. *op-node
atv1.11.1
*op-geth
at [v1.101500.0
](https://github.com/et...(AI_EN_LECTOR_REPLACEMENT_SPACE)
No description provided.