Skip to content

Conversation

@krofax
Copy link
Contributor

@krofax krofax commented Mar 27, 2025

Description

This PR addresses the issues identified in #1327 regarding the "Running a Local Development Environment" tutorial.

Changes:

  • Corrected the funding description to accurately reflect that the setup script pre-funds accounts on L2 directly, not L1
  • Removed misleading instructions about bridging ETH from L1 to L2
  • Added clear verification steps for checking L2 account balances
  • Updated the troubleshooting section with links to GitHub issues and Discord support
  • Added an informational callout to emphasize the L2 pre-funding behavior
  • Improved commands and environment variable examples for better usability

Tests

Additional context

Metadata

@krofax krofax requested a review from a team as a code owner March 27, 2025 03:16
@netlify
Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit fd62d06
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67e4d32c5c459a0008fb8351
😎 Deploy Preview https://deploy-preview-1538--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 27, 2025

📝 Walkthrough

Walkthrough

This pull request updates documentation related to the development network and L2 interactions. In the "Debug before deploying" section of the app developers’ guide, the URL for the development network has been changed from /stack/dev-net to /operators/chain-operators/tutorials/chain-dev-net. The local development guide in pages/stack/dev-net.mdx has been completely removed. The chain devnet tutorial has been restructured with renamed sections, updated instructions for checking L2 balances using the cast tool, and a new section on interacting with L2, including deployment and transaction examples. Additionally, the redirection rules in the public/_redirects file have been modified to point the old URL to the new destination, and entries have been removed from words.txt.

Assessment against linked issues

Objective Addressed Explanation
Update funding description to accurately reflect L2 account funding
Remove or update text about moving ETH to L2
Clarify that setup script handles L2 funding
Fix/update link to Chain Operators Troubleshooting Guide No updates made to the broken link as required.
Add verification steps for L2 account funding No verification steps for L2 account funding were added.

Possibly related PRs

  • fixing redirect to superchain explainer #1502: The changes in the main PR, which update a URL related to the development network, are directly related to the changes in the retrieved PR that also involve a redirect for the same development network URL.
  • Move tools to their own directory #1245: The changes in the main PR, which update a URL related to the development network, are related to the retrieved PR as both involve modifications to redirect rules that affect the same development network resources.
  • Add public docs for OP Stack network topologies #1167: The changes in the main PR, which update a URL related to the development network, are directly related to the modifications in the retrieved PR that also involve the same URL being redirected to a new location.

Suggested labels

do-not-merge

Suggested reviewers

  • sbvegan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx (3)

175-186: Improved instructions for checking L2 balance

The updated instructions provide clearer steps with environment variables and explicit commands for checking the balance on L2, which is more user-friendly.

Consider adding additional clarification for the L2 RPC port placeholder:

-export L2_RPC_URL="http://127.0.0.1:<L2-RPC-PORT>"  # Replace with your actual L2 RPC port
+export L2_RPC_URL="http://127.0.0.1:<L2-RPC-PORT>"  # Replace <L2-RPC-PORT> with the port number from the op-el service (e.g., 33643)

190-204: Helpful new section on L2 interaction

The added section with examples for sending transactions and deploying contracts provides valuable practical guidance for users. This aligns with the PR objectives to improve the tutorial's usability.

Consider providing more specific guidance for the placeholder values:

-    <RECIPIENT-ADDRESS> \
+    <RECIPIENT-ADDRESS> \  # Replace with any Ethereum address you want to send to

215-215: Improved troubleshooting resources

Adding a reference to the Optimism Discord provides users with an additional support option beyond just filing GitHub issues, which enhances the troubleshooting section.

The sentence contains a repeated "please" which could be simplified:

-*   If you run into any problems, please [file an issue](https://github.com/ethereum-optimism/optimism/issues) or join the [Optimism Discord](https://discord.optimism.io/) for help.
+*   If you run into any problems, [file an issue](https://github.com/ethereum-optimism/optimism/issues) or join the [Optimism Discord](https://discord.optimism.io/) for help.
🧰 Tools
🪛 LanguageTool

[style] ~215-~215: This sentence already contains the adverb “please”. Consider removing one of them.
Context: ...ting) * If you run into any problems, please [file an issue](https://github.com/ethe...

(REPEATED_PLEASE)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d231fac and c803045.

📒 Files selected for processing (5)
  • pages/app-developers/building-apps.mdx (1 hunks)
  • pages/operators/chain-operators/tutorials/chain-dev-net.mdx (2 hunks)
  • pages/stack/dev-net.mdx (0 hunks)
  • public/_redirects (1 hunks)
  • words.txt (0 hunks)
💤 Files with no reviewable changes (2)
  • words.txt
  • pages/stack/dev-net.mdx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:
    pnpm validate-metadata
    ```'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/app-developers/building-apps.mdx
  • pages/operators/chain-operators/tutorials/chain-dev-net.mdx
🪛 LanguageTool
pages/operators/chain-operators/tutorials/chain-dev-net.mdx

[grammar] ~170-~170: This phrase is duplicated. You should probably use “test test” only once.
Context: ...d development addresses on L2 using the `test test test test test test test test test test test junk...

(PHRASE_REPETITION)


[style] ~215-~215: This sentence already contains the adverb “please”. Consider removing one of them.
Context: ...ting) * If you run into any problems, please [file an issue](https://github.com/ethe...

(REPEATED_PLEASE)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (5)
pages/app-developers/building-apps.mdx (1)

64-64: Correctly updated URL for development network

The link to the development network has been updated to point to the new location at /operators/chain-operators/tutorials/chain-dev-net. This change aligns with the redirect rules that have been added.

public/_redirects (1)

81-82: Good addition of redirect for development network

The added redirect rule ensures that users following old links to /stack/dev-net will be correctly directed to the new location at /chain-operators/tutorials/chain-dev-net. This redirect is properly formatted and maintains good user experience by preventing broken links.

pages/operators/chain-operators/tutorials/chain-dev-net.mdx (3)

164-168: Clear improvement in section title and explanatory callout

The section title has been updated to better reflect the actual process - using pre-funded accounts rather than depositing funds. The added callout provides important clarification that accounts are automatically pre-funded on L2, eliminating confusion about the need to bridge funds from L1.


170-174: Clear explanation of pre-funded accounts setup

The text provides helpful context about the pre-funded development addresses and the mnemonic used, which aligns with the PR objectives to improve clarity in the tutorial.

🧰 Tools
🪛 LanguageTool

[grammar] ~170-~170: This phrase is duplicated. You should probably use “test test” only once.
Context: ...d development addresses on L2 using the `test test test test test test test test test test test junk...

(PHRASE_REPETITION)


188-189: Clear confirmation about pre-funded accounts

This additional text helps users understand what to expect when checking their balance, confirming that the account should already have ETH on L2.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx (3)

23-23: Header Style: Use Sentence Case for H1
The H1 header currently reads "Running a Local Development Environment." According to our style guidelines for headers, consider using sentence case (e.g., "Running a local development environment") to maintain consistency across documentation.

-# Running a Local Development Environment
+# Running a local development environment

178-182: Test Mnemonic Presentation: Consider Clarifying the Repetition
The sentence

"Your network is configured to pre-fund development addresses on L2 using the test test test test test test test test test test test junk mnemonic."
uses a repetitive pattern that, while standard as a BIP39 test mnemonic, might appear duplicated to some readers. Consider clarifying that this is the well-known test mnemonic to avoid confusion.

-using the `test test test test test test test test test test test junk` mnemonic.
+using the standard BIP39 test mnemonic `test test test test test test test test test test test junk`.
🧰 Tools
🪛 LanguageTool

[grammar] ~178-~178: This phrase is duplicated. You should probably use “test test” only once.
Context: ...d development addresses on L2 using the `test test test test test test test test test test test junk...

(PHRASE_REPETITION)


221-224: Next Steps: Refine Repetitive 'please' Usage
In the bullet point that reads:
"* If you run into any problems, please file an issue or join the Optimism Discord for help."
the word "please" appears redundantly. Consider removing one instance to streamline the sentence.

-*   If you run into any problems, please [file an issue](https://github.com/ethereum-optimism/optimism/issues) or join the [Optimism Discord](https://discord.optimism.io/) for help.
+*   If you run into any problems, [file an issue](https://github.com/ethereum-optimism/optimism/issues) or join the [Optimism Discord](https://discord.optimism.io/) for help.
🧰 Tools
🪛 LanguageTool

[style] ~223-~223: This sentence already contains the adverb “please”. Consider removing one of them.
Context: ...ting) * If you run into any problems, please [file an issue](https://github.com/ethe...

(REPEATED_PLEASE)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c803045 and fd62d06.

📒 Files selected for processing (1)
  • pages/operators/chain-operators/tutorials/chain-dev-net.mdx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:
    pnpm validate-metadata
    ```'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/operators/chain-operators/tutorials/chain-dev-net.mdx
🪛 LanguageTool
pages/operators/chain-operators/tutorials/chain-dev-net.mdx

[grammar] ~178-~178: This phrase is duplicated. You should probably use “test test” only once.
Context: ...d development addresses on L2 using the `test test test test test test test test test test test junk...

(PHRASE_REPETITION)


[style] ~223-~223: This sentence already contains the adverb “please”. Consider removing one of them.
Context: ...ting) * If you run into any problems, please [file an issue](https://github.com/ethe...

(REPEATED_PLEASE)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (5)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx (5)

1-18: Frontmatter Verification: Metadata is Complete and Correct
The frontmatter contains all the required fields (title, description, lang, content_type, topic, personas, and categories) with non-empty values.


157-163: Kurtosis Web UI Callout: Clear and Helpful
The newly added callout that explains using the Kurtosis Web UI is clear and valuable for users who prefer a graphical interface.


174-177: L2 Pre-funding Callout: Clarity on Funding Behavior
The callout clearly informs users that the setup script automatically pre-funds accounts on L2, eliminating the need to bridge from L1. This aligns well with the PR objectives.


185-194: L2 Balance Check: Clear and Actionable Example
The code block for checking the L2 balance is clear and includes helpful comments (e.g., reminding users to replace <L2-RPC-PORT> with their actual port).


202-212: L2 Transaction Example: Well Documented
The examples for sending a transaction and deploying a contract on L2 are clear and instructive. The use of cast is appropriate for the intended audience.

@krofax krofax merged commit 37cd811 into main Apr 1, 2025
8 checks passed
@krofax krofax deleted the devnet-tut branch April 1, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Fix : Running a Local Development Environment Tutorial

3 participants