Skip to content

Move tools to their own directory #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Jan 14, 2025

We are rearranging the interop docs to have the explainers on top, and then a subgroup for tools and another for tutorials.

@qbzzt qbzzt requested a review from a team as a code owner January 14, 2025 22:28
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 82a99b5
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/6786eaf2d650ce0008179418
😎 Deploy Preview https://deploy-preview-1245--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sbvegan
Copy link
Collaborator

sbvegan commented Jan 14, 2025

Hey @qbzzt, can you set up a redirect from the old path to the new path in the /public/_redirects file?

Copy link
Contributor

coderabbitai bot commented Jan 14, 2025

Warning

Rate limit exceeded

@qbzzt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c27466f and 82a99b5.

📒 Files selected for processing (3)
  • next.config.mjs (1 hunks)
  • pages/builders/app-developers/tools/supersim.mdx (1 hunks)
  • public/_redirects (2 hunks)
📝 Walkthrough

Walkthrough

This pull request introduces structural changes to the documentation navigation and routing for the Interop section. The modifications involve creating a new "tools" subdirectory within the Interop section and relocating "supersim" and "devnet" content to this new location. Specifically, redirect rules have been added to the Next.js configuration to ensure existing links are properly forwarded. The _meta.json files have been updated to reflect these changes, with entries for "supersim" and "devnet" being moved from the main Interop directory to the new tools subdirectory. The devnet page has also been updated with a "Coming Soon" title and additional documentation details about the Interop devnet.

Sequence Diagram

sequenceDiagram
    participant User
    participant Router
    participant NextConfig
    participant InteropPage

    User->>Router: Request /stack/interop/supersim
    Router->>NextConfig: Check redirects
    NextConfig-->>Router: Redirect to /stack/interop/tools/supersim
    Router->>InteropPage: Load new page
Loading

Possibly related PRs

Suggested reviewers

  • bradleycamacho
  • krofax
  • sbvegan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
pages/stack/interop/tools/devnet.mdx (1)

Line range hint 15-67: Uncomment the documentation content

The commented block contains valuable information about the devnet that should be visible to users. Consider uncommenting this section while keeping the "Coming Soon" notice at the top.

🧹 Nitpick comments (3)
pages/stack/interop/_meta.json (1)

8-8: Ensure consistent capitalization in navigation items

According to the coding guidelines, navigation items should use title case. Consider updating to "Tools" to maintain consistency with other entries like "Interop explainer" and "Cross-chain security".

-    "tools": "Tools"
+    "tools": "Tools"
pages/stack/interop/tools/devnet.mdx (2)

2-2: Use title case for the page title

According to the documentation guidelines, page titles should use title case.

-title: Interop Devnet - Coming Soon
+title: Interop Devnet - Coming Soon

9-9: Use sentence case for the header

According to the documentation guidelines, headers should use sentence case while preserving the capitalization of technical terms like "Interop".

-# Interop Devnet - Coming Soon
+# Interop devnet - coming soon
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b81bdc and c27466f.

📒 Files selected for processing (4)
  • next.config.mjs (1 hunks)
  • pages/stack/interop/_meta.json (1 hunks)
  • pages/stack/interop/tools/_meta.json (1 hunks)
  • pages/stack/interop/tools/devnet.mdx (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • pages/stack/interop/tools/_meta.json
🧰 Additional context used
📓 Path-based instructions (1)
pages/stack/interop/tools/devnet.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🔇 Additional comments (1)
next.config.mjs (1)

31-40: Redirect configuration looks good!

The new redirect rules appropriately handle the tools directory restructuring, maintaining backward compatibility for existing links.

Copy link
Contributor

coderabbitai bot commented Jan 14, 2025

📝 Walkthrough

Walkthrough

This pull request involves a comprehensive documentation restructuring focusing on the Interop and Tools sections. The changes include updates to configuration files, metadata, and redirect rules. In next.config.mjs, redirects for specific interop paths were removed, with a recommendation to use the public/_redirects file instead. The pages/stack/interop/_meta.json file was modified by removing "devnet" and "supersim" entries and adding a new "tools" entry. A new pages/stack/interop/tools/_meta.json was created with entries for "supersim" and "devnet". The devnet.mdx file was updated with a "Coming Soon" title and additional context about the Interop devnet. The public/_redirects file underwent extensive modifications, updating numerous redirect paths to reflect the new documentation structure and adding new redirect rules for interop-related pages.

Suggested labels

flag:merge-pending-release

Suggested reviewers

  • sbvegan
  • bradleycamacho

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pages/stack/interop/tools/devnet.mdx (1)

Line range hint 15-68: Consider using a draft PR or separate branch for unreleased content.

The commented-out content contains valuable information but might be better managed in a draft PR or separate branch until ready for release.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b81bdc and 4fd96f8.

📒 Files selected for processing (5)
  • next.config.mjs (1 hunks)
  • pages/stack/interop/_meta.json (1 hunks)
  • pages/stack/interop/tools/_meta.json (1 hunks)
  • pages/stack/interop/tools/devnet.mdx (2 hunks)
  • public/_redirects (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • next.config.mjs
  • pages/stack/interop/tools/_meta.json
🧰 Additional context used
📓 Path-based instructions (1)
pages/stack/interop/tools/devnet.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🔇 Additional comments (3)
public/_redirects (1)

120-124: LGTM! The new redirects align with the PR objectives.

The new redirects properly support the reorganization of tools into their own directory while maintaining accessibility through the old paths.

pages/stack/interop/_meta.json (1)

7-8: LGTM! The navigation structure properly reflects the tools reorganization.

The metadata changes maintain the existing security entry while adding a new tools section, consistent with the PR's goal of moving tools to their own directory.

pages/stack/interop/tools/devnet.mdx (1)

2-2: LGTM! Clear indication of work-in-progress status.

The title update and warning callout effectively communicate the current state of the devnet to users.

Also applies to: 9-13

@qbzzt
Copy link
Contributor Author

qbzzt commented Jan 14, 2025

Hey @qbzzt, can you set up a redirect from the old path to the new path in the /public/_redirects file?

Consider it done.

@krofax krofax merged commit 97fed14 into ethereum-optimism:main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants