Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate loading config and genesis files #482

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Separate loading config and genesis files #482

merged 2 commits into from
Jan 28, 2025

Conversation

mslipper
Copy link
Contributor

No description provided.

@mslipper mslipper requested a review from a team as a code owner January 28, 2025 17:52
@mslipper mslipper requested a review from tynes January 28, 2025 17:52
Inphi
Inphi approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! This will cut down execution on the fault proof by a ton.

@mslipper mslipper enabled auto-merge (squash) January 28, 2025 18:27
@mslipper mslipper merged commit 7496603 into optimism Jan 28, 2025
6 of 7 checks passed
@mslipper mslipper deleted the feat/separate-config-loading branch January 28, 2025 18:36
ajsutton added a commit to ethereum-optimism/optimism that referenced this pull request Jan 30, 2025
@ajsutton
op-geth: Update op-geth to avoid loading and parsing all genesis files.
b579f6e 
Specifically includes ethereum-optimism/op-geth#482
@ajsutton ajsutton mentioned this pull request Jan 30, 2025
Merged
github-merge-queue bot pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 30, 2025
@ajsutton @mslipper
Fix cannon e2e tests (#14060)
7b53454 
* ci: Raise parallelism of cannon-e2e tests

* ci: Build op-program-host and cannon before running go tests.

* op-geth: Update op-geth to avoid loading and parsing all genesis files.

Specifically includes ethereum-optimism/op-geth#482

* Consistently build 64-bit multithreaded prestates with -mt64 suffix.

Previously the native build used -mt and the reproducible build used -mt64.
Stop building the 32-bit multithreaded prestate in reproducible builds.

---------

Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inphi Inphi Inphi approved these changes

@tynes tynes Awaiting requested review from tynes tynes is a code owner automatically assigned from ethereum-optimism/op-geth-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mslipper @Inphi