Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannon e2e tests #14060

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Fix cannon e2e tests #14060

merged 4 commits into from
Jan 30, 2025

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Jan 30, 2025

Description

  • Builds op-program-host and cannon for go tests as make reproducible-prestate will not build them locally
  • Stop building 32-bit multithreaded cannon prestates as they are not used and will not be shipped to production
  • Consistently build 64-bit multithreaded cannon prestates with -mt64 suffix.
  • Update op-geth to include Separate loading config and genesis files op-geth#482 and avoid loading all genesis files

Replaces #14016 with a cleaned up change history.

@ajsutton ajsutton requested review from a team as code owners January 30, 2025 01:08
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.42%. Comparing base (491b2a5) to head (0df8115).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14060      +/-   ##
===========================================
- Coverage    46.53%   46.42%   -0.11%     
===========================================
  Files          989      989              
  Lines        83610    83610              
===========================================
- Hits         38904    38816      -88     
- Misses       41767    41863      +96     
+ Partials      2939     2931       -8     
Flag Coverage Δ
cannon-go-tests-32 61.99% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.62% <ø> (-1.66%) ⬇️
contracts-bedrock-tests 95.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

@ajsutton ajsutton added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit 7b53454 Jan 30, 2025
49 checks passed
@ajsutton ajsutton deleted the aj/fix-cannon-e2e branch January 30, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants