feat/interop: create OptimismPortalInterop

[0xfuturistic]

OptimismPortalInterop is created per the specs and OptimismPortal is updated such that OptimismPortalInterop can successfully inherit from it. This PR implements the OptimismPortalInterop, OptimismPortal changes from #10452, which was closed in support of smaller PRs

[coderabbitai]

Walkthrough

The changes involve updates to contracts in the OptimismPortal and OptimismPortalInterop files. The OptimismPortal contract now includes a transformation of the version constant into a pure virtual function returning "2.8.0" and the addition of the virtual modifier to the setGasPayingToken function. Additionally, a new contract OptimismPortalInterop has been introduced to facilitate communication between Layer 1 and Layer 2 in the Optimism network, with added methods for setting configuration options and error handling.

Changes

File Path	Change Summary
packages/contracts-bedrock/src/L1/OptimismPortal.sol	Converted version constant to a pure virtual function returning "2.8.0" and added virtual modifier to setGasPayingToken.
packages/contracts-bedrock/src/L1/OptimismPortalInterop.sol	Introduced OptimismPortalInterop contract with added functionality for L1-L2 message passing, including imports, error handling, overridden version function, and setConfig method.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ajsutton]

Shouldn't we be building new functionality on OptimismPortal2 or are we deliberately doing this without fault proofs (and will have to reimplement in the future)?

[tynes]

Shouldn't we be building new functionality on OptimismPortal2 or are we deliberately doing this without fault proofs (and will have to reimplement in the future)?

We will merge portal2 and portal functionality at some point in the future, interop devnet doesn't support fault proofs

[semgrep-app]

Semgrep found 3 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/src/libraries/StaticConfig.sol
  • L21 - Triage
  • L36 - Triage
  • L50 - Triage

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

[tynes]

Needs tests

[tynes]

Build is failing in CI

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.26%. Comparing base (60faf8b) to head (532be0d).

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10585       +/-   ##
============================================
- Coverage    55.13%   39.26%   -15.88%     
============================================
  Files           37       27       -10     
  Lines         2900     1821     -1079     
  Branches       415      415               
============================================
- Hits          1599      715      -884     
+ Misses        1269     1106      -163     
+ Partials        32        0       -32     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes