-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/interop: create SystemConfigInterop
, OptimismPortalInterop
+ update L1BlockInterop
#10452
Conversation
WalkthroughThe updates across various contracts in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (1)
packages/contracts-bedrock/test/L1/OptimismPortal.t.sol (1)
Line range hint
699-699
: Avoid usingblockhash(block.number)
as it always returns 0, which might not be the intended behavior.- proposal.outputRoot, optimismPortal.l2Oracle().nextBlockNumber(), blockhash(block.number), block.number + proposal.outputRoot, optimismPortal.l2Oracle().nextBlockNumber(), blockhash(block.number - 1), block.number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10452 +/- ##
============================================
- Coverage 42.36% 29.22% -13.15%
============================================
Files 73 31 -42
Lines 4836 2898 -1938
Branches 766 614 -152
============================================
- Hits 2049 847 -1202
+ Misses 2680 1976 -704
+ Partials 107 75 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
ac6bf98
to
dbe5977
Compare
1db22dd
to
87d2d34
Compare
4c30272
to
ef40d4e
Compare
6839e64
to
0997319
Compare
Semgrep found 3 No Semgrep found 1 Detected a network listener listening on 0.0.0.0 or an empty string. This could unexpectedly expose the server publicly as it binds to all available interfaces. Instead, specify another IP address that is not 0.0.0.0 nor the empty string. Ignore this finding from avoid-bind-to-all-interfaces.Semgrep found 1 Please create a GitHub ticket for this TODO. Ignore this finding from todos_require_linear.Semgrep found 1 superfluous nil err check before return Ignore this finding from err-nil-check. |
89dbd3f
to
cc7dd02
Compare
// For ADD_DEPENDENCY config type | ||
if (_type == ConfigType.ADD_DEPENDENCY) { | ||
uint256 chainId = abi.decode(_value, (uint256)); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going back and forth on whether or not this should revert if its already in the dep set
they are moved to a new branch specifically for their development
Semgrep found 4
Found banned use of |
SystemConfigInterop
, OptimismPortalInterop
+ update L1BlockInterop
split up this PR into these smaller PRs: |
No description provided.