feat/interop: create SystemConfigInterop

[0xfuturistic]

SystemConfigInterop is created per the specs and SystemConfig is updated such that SystemConfigInterop can successfully inherit from it. This PR implements the SystemConfigInterop, SystemConfig changes from #10452, which was closed in support of smaller PRs

[coderabbitai]

Walkthrough

The updates primarily involve refactoring the version constant into a function across several contracts, adding virtual modifiers to specific functions, and introducing new interop contracts (OptimismPortalInterop and SystemConfigInterop) that extend existing contracts to enhance functionality for handling configurations and interoperability between Layer 1 and Layer 2 in the Optimism network.

Changes

File Path	Change Summary
.../contracts-bedrock/src/L1/OptimismPortal.sol	Converted version constant to a function; added virtual to setGasPayingToken.
.../contracts-bedrock/src/L1/OptimismPortalInterop.sol	Introduced OptimismPortalInterop contract; added Unauthorized error, version override, and setConfig function.
.../contracts-bedrock/src/L1/SystemConfig.sol	Changed version to a function; made _setGasPayingToken internal and virtual.
.../contracts-bedrock/src/L1/SystemConfigInterop.sol	Added SystemConfigInterop contract; included new functions and errors for managing L1 configuration and interop.
.../contracts-bedrock/scripts/Deploy.s.sol	Updated deployment logic to conditionally deploy SystemConfig or SystemConfigInterop based on configuration.
.../contracts-bedrock/test/kontrol/scripts/run-kontrol.sh	Modified test list array: added one test case, removed two related to OptimismPortal2Kontrol.
.../contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummary.sol	Updated systemConfigAddress constant value.
.../contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummaryFaultProofs.sol	Updated systemConfigAddress constant value.
.../contracts-bedrock/test/vendor/Initializable.t.sol	Modified assertion in Initializer_Test contract related to the number of initializable contracts.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[semgrep-app]

Semgrep found 2 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/src/L1/OptimismPortalInterop.sol
  • L19 - Triage
• packages/contracts-bedrock/src/L1/OptimismPortal.sol
  • L132 - Triage

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

[semgrep-app]

Semgrep found 3 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/src/libraries/StaticConfig.sol
  • L21 - Triage
  • L36 - Triage
  • L50 - Triage

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

[tynes]

Generally looks good but needs tests

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.26%. Comparing base (4c3f63d) to head (ce73cb5).

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10586       +/-   ##
============================================
- Coverage    55.13%   39.26%   -15.88%     
============================================
  Files           37       27       -10     
  Lines         2900     1821     -1079     
  Branches       415      415               
============================================
- Hits          1599      715      -884     
+ Misses        1269     1106      -163     
+ Partials        32        0       -32     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes