contracts-bedrock: default to governance being off #13377
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent people from accidentally deploying GovToken with the same name as OP colliding with OP Mainnet's token, turn off by default. `op-deployer` should be doing this already, just doing this for people who deploy through the legacy path. See celo-org#280 (comment) for context.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13377 +/- ##
===========================================
- Coverage 47.23% 45.93% -1.31%
===========================================
Files 939 882 -57
Lines 78469 73710 -4759
Branches 796 796
===========================================
- Hits 37066 33855 -3211
+ Misses 38669 37262 -1407
+ Partials 2734 2593 -141
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I'll need to update this in OPD too. Stand by. |
mslipper
approved these changes
Dec 12, 2024
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
To prevent people from accidentally deploying GovToken with the same name as OP colliding with OP Mainnet's token, turn off by default. `op-deployer` should be doing this already, just doing this for people who deploy through the legacy path. See celo-org#280 (comment) for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent people from accidentally deploying GovToken with the same
name as OP colliding with OP Mainnet's token, turn off by default.
op-deployershould be doing this already, just doing this for peoplewho deploy through the legacy path.
See celo-org#280 (comment)
for context.