Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Default gov token to disabled #13378

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.78%. Comparing base (d386df3) to head (f7464bc).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13378      +/-   ##
===========================================
- Coverage    47.23%   45.78%   -1.45%     
===========================================
  Files          939      882      -57     
  Lines        78469    73710    -4759     
  Branches       796      796              
===========================================
- Hits         37066    33751    -3315     
+ Misses       38669    37408    -1261     
+ Partials      2734     2551     -183     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 89.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/state/deploy_config.go 82.75% <100.00%> (ø)

... and 65 files with indirect coverage changes

Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Ignore, I already added it.

Makes sense to me. If you think it's worthwhile, adding an assertion to this test too might be useful:

func TestGlobalOverrides(t *testing.T) {
though non-blocking.

@mslipper mslipper added this pull request to the merge queue Dec 13, 2024
Merged via the queue into develop with commit 4d5d7ad Dec 13, 2024
42 checks passed
@mslipper mslipper deleted the feat/default-no-gov branch December 13, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants