-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: L2 genesis generation #9792
Conversation
|
||
mapping(address => string) internal names; | ||
|
||
function name() public pure override returns (string memory) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Named return arguments to functions must be appended with an underscore (_
)
|
||
_loadAddresses(string.concat(vm.projectRoot(), "/deployments/", deploymentContext, "/.deploy")); | ||
/// @dev Creates a mapping of predeploy addresses to their names. This needs to be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer @notice
over @dev
in natspec comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9792 +/- ##
===========================================
- Coverage 28.52% 0.60% -27.92%
===========================================
Files 164 91 -73
Lines 7214 2463 -4751
Branches 1324 575 -749
===========================================
- Hits 2058 15 -2043
+ Misses 5050 2448 -2602
+ Partials 106 0 -106
Flags with carried forward coverage won't be shown. Click here to find out more.
|
TODO: wait for ethereum-optimism#9792 and initialize accordingly
TODO: wait for ethereum-optimism#9792 and initialize accordingly
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Semgrep found 2 Prefer Semgrep found 1 Iteration over a possibly empty map Semgrep found 2
Please create a GitHub ticket for this TODO. Ignore this finding from todos_require_linear. |
Closing in favor of #10106 where I'll continue the work |
Description
Draft PR for L2 genesis generation using solidity. The test currently takes too long to run. Already optimized it to be much slower than it was