Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes for randao #18

Merged
merged 13 commits into from
Jul 11, 2024
Merged

changes for randao #18

merged 13 commits into from
Jul 11, 2024

Conversation

blockchaindevsh
Copy link

@blockchaindevsh blockchaindevsh commented Mar 16, 2024 •
edited
Loading

add L1Block.blockHash to fetch 8191 history L1 blockhash not including the current one.

TODO:

  1. add e2e test

qizhou
qizhou reviewed Mar 16, 2024
View reviewed changes
Copy link

@qizhou qizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate the two features (SoulETH and RANDAO) into two PRs?

packages/contracts-bedrock/src/L2/L1Block.sol Outdated Show resolved Hide resolved
@blockchaindevsh
Copy link
Author

blockchaindevsh commented Mar 16, 2024 •
edited
Loading

Can we separate the two features (SoulETH and RANDAO) into two PRs?

SoulETH related changes are moved here.

ES part is moved here

@blockchaindevsh blockchaindevsh mentioned this pull request Mar 19, 2024
Closed
@blockchaindevsh blockchaindevsh changed the title changes of optimism side changes for randao Mar 21, 2024
qzhodl
qzhodl reviewed Jun 13, 2024
View reviewed changes
packages/contracts-bedrock/src/L2/L1Block.sol
} else {
lower = upper - HISTORY_SIZE + 1;
}
if (_historyNumber >= lower && _historyNumber < upper) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_historyNumber <= upper ?

@blockchaindevsh blockchaindevsh merged commit 08f515c into ethstorage:op-es Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qzhodl qzhodl qzhodl approved these changes

@qizhou qizhou qizhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blockchaindevsh @qizhou @qzhodl @zhiqiangxu