Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Wrong Input Length - ERC165 Example #1640

Merged
merged 3 commits into from
May 22, 2019
Merged

Fix Wrong Input Length - ERC165 Example #1640

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac24145
Wrong input size - noThrowCall ERC165
Dec 7, 2018
47962c9
Add version history section to EIP165
Agusx1211 Jan 23, 2019
1eca391
EIP 1640 -> PR 1640
Agusx1211 Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion EIPS/eip-165.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ contract ERC165Query {
30000, // 30k gas
_contract, // To addr
x, // Inputs are stored at location x
0x20, // Inputs are 32 bytes long
0x24, // Inputs are 36 bytes long
x, // Store output over input (saves space)
0x20) // Outputs are 32 bytes long

Expand Down Expand Up @@ -224,6 +224,11 @@ contract Homer is ERC165, Simpson {

With three or more supported interfaces (including ERC165 itself as a required supported interface), the mapping approach (in every case) costs less gas than the pure approach (at worst case).

## Version history
* EIP 1640, finalized 2019-01-23 -- This corrects the noThrowCall test case to use 36 bytes rather than the previous 32 bytes. The previous code was an error that still silently worked in Solidity 0.4.x but which was broken by new behavior introduced in Solidity 0.5.0. This change was discussed at [#1640](https://github.com/ethereum/EIPs/pull/1640).
Agusx1211 marked this conversation as resolved.
Show resolved Hide resolved

* EIP 165, finalized 2018-04-20 -- Original published version.

## Copyright

Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).