-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Process page to eips.ethereum.org #1932
Conversation
Merge commits from main repo into fork
index.html
Outdated
@@ -7,10 +7,10 @@ <h1 class="page-heading">EIPs | |||
<a href="https://gitter.im/ethereum/EIPs?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge"><img src="https://badges.gitter.im/Join%20Chat.svg" alt="Gitter"></a> | |||
<a href="/last-call.xml"><img src="https://img.shields.io/badge/rss-Last Calls-red.svg" alt="RSS"></a> | |||
</h1> | |||
<p>Ethereum Improvement Proposals (EIPs) describe standards for the Ethereum platform, including core protocol specifications, client APIs, and contract standards.</p> | |||
<p>Ethereum Improvement Proposals (EIPs) describe standards for the Ethereum platform, including core protocol specifications, client APIs, and contract standards. For more information on the EIPs process, see <a href="{{"process"|relative_url}}">Process</a> ({{site.pages|where:"type","Process"|size}}).</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the expression at the end for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... I'm honestly not sure. I tried to copy the format for other links, but haven't found any info on how to build this locally to try it out. See this for a similar example: https://github.com/ethereum/EIPs/pull/1932/files/38b0bc1d5f6420c629d006ae8c0c506395052789#diff-eacf331f0ffc35d4b482f1d15a887d3bR32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
({{site.pages|where:"type","Process"|size}})
outputs the number of pages with 'type: Process'. I don't think you need it here.
Building locally is just a matter of following the instructions for building a Github Pages Jekyll site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Managed to build locally. Will update soon.
Added some small changes to the |
@timbeiko Could you look into the build failure? |
@nicksavers done! |
I think it would make sense dropping most of the content from
|
@axic Thank you for the feedback! I had a previous PR merged in to make the |
I think any of those options are good as long as we do not have 3 sources of information 😉 My preference would probably be an overhaul of EIP-1:
Point 2) is what the README and this PR tries to accomplish. |
Closing in favor of #1991 |
The Ethereum Cat Herders have been trying to improve the legibility of the EIP process within Ethereum. This PR adds a Process page to eips.ethereum.org to describe the non-technical elements of the process. The contents of the page are inspired by this Ethereum Magicians thread, specifically @bmann's blog post and this tweetstorm.