Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand EIP Championing Section in EIP-1 #1991

Merged
merged 6 commits into from
Jul 13, 2019
Merged

Expand EIP Championing Section in EIP-1 #1991

merged 6 commits into from
Jul 13, 2019

Conversation

timbeiko
Copy link
Contributor

@timbeiko timbeiko commented May 3, 2019

This PR serves as a replacement for #1932.

The Ethereum Cat Herders have been trying to improve the legibility of the EIP process within Ethereum. In order to minimize the amount of resources to be maintained, this PR expands some of the EIP championing sections of EIP-1. The contents of the page are inspired by this Ethereum Magicians thread, specifically @bmann's blog post and this tweetstorm.

Feedback welcome 😁

EIPS/eip-1.md Outdated Show resolved Hide resolved
Co-Authored-By: timbeiko <t.beiko23@gmail.com>
@axic axic added the meta label May 10, 2019
@timbeiko
Copy link
Contributor Author

@axic @nicksavers do you think it makes sense to give this a final shout-out on the next AllCoreDevs and merge it if there are no objections/comments shortly after?

@axic
Copy link
Member

axic commented May 30, 2019

@Souptacular @Arachnid @cdetrio @gcolvin can you approve?

EIPS/eip-1.md Outdated Show resolved Hide resolved
@timbeiko
Copy link
Contributor Author

timbeiko commented Jun 12, 2019

Lucky me, AllCoreDevs got pushed back a week 😅

I've added another commit where I tried to take all of your feedback into account, @nicksavers @MadeofTin @carver. Will leave some inline comments as well.

@nicksavers to keep this PR small, I didn't add anything about expiry dates.

EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Show resolved Hide resolved
Based on @carver's comments.
EIPS/eip-1.md Outdated Show resolved Hide resolved
Rephrase based on review feedback
@timbeiko
Copy link
Contributor Author

@loredanacirstea @Arachnid I've incorporated your feedback in the latest commit. Could you please 👍 if it looks good to you? Thank you!

@kriszrtina
Copy link

@MadeofTin another edit based on your feedback, re: "community interest" not block for Draft, but potentially blocking afterwards.

While "community interest" will not be a factor in deciding whether an EIP gets merged as a draft, insufficient community interest may prevent your EIP from moving forward, especially if it is a Core EIP.

@timbeiko
Copy link
Contributor Author

@kriszrtina I removed that sentence in favor of @loredanacirstea, which I felt better phrased the same sentiment:

Negative community feedback will be taken into consideration and may prevent your EIP from moving past the Draft stage.

@axic
Copy link
Member

axic commented Jul 13, 2019

I'm merging this because three editors have approved, it has been discussed at ACD a few times and it documents the current process. Without judging the current process, at least having it well documented is a good starting point to change it. It is clear what is being changed.

@axic axic merged commit 4a488ee into ethereum:master Jul 13, 2019
@timbeiko timbeiko deleted the patch-1 branch July 13, 2019 21:26
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
* Update eip-1.md

* Update EIPS/eip-1.md

Co-Authored-By: timbeiko <t.beiko23@gmail.com>

* Update EIP-1 based on reviewer feedback

* Remove qualifiers

Based on @carver's comments.

* Rephrase based on review feedback

Rephrase based on review feedback
MadeofTin pushed a commit to MadeofTin/EIPs that referenced this pull request Nov 13, 2019
* Update eip-1.md

* Update EIPS/eip-1.md

Co-Authored-By: timbeiko <t.beiko23@gmail.com>

* Update EIP-1 based on reviewer feedback

* Remove qualifiers

Based on @carver's comments.

* Rephrase based on review feedback

Rephrase based on review feedback
BelfordZ pushed a commit to BelfordZ/EIPs that referenced this pull request Dec 13, 2019
* Update eip-1.md

* Update EIPS/eip-1.md

Co-Authored-By: timbeiko <t.beiko23@gmail.com>

* Update EIP-1 based on reviewer feedback

* Remove qualifiers

Based on @carver's comments.

* Rephrase based on review feedback

Rephrase based on review feedback
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
* Update eip-1.md

* Update EIPS/eip-1.md

Co-Authored-By: timbeiko <t.beiko23@gmail.com>

* Update EIP-1 based on reviewer feedback

* Remove qualifiers

Based on @carver's comments.

* Rephrase based on review feedback

Rephrase based on review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants