-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand EIP Championing Section in EIP-1 #1991
Conversation
Co-Authored-By: timbeiko <t.beiko23@gmail.com>
@axic @nicksavers do you think it makes sense to give this a final shout-out on the next AllCoreDevs and merge it if there are no objections/comments shortly after? |
@Souptacular @Arachnid @cdetrio @gcolvin can you approve? |
Lucky me, AllCoreDevs got pushed back a week 😅 I've added another commit where I tried to take all of your feedback into account, @nicksavers @MadeofTin @carver. Will leave some inline comments as well. @nicksavers to keep this PR small, I didn't add anything about expiry dates. |
Based on @carver's comments.
Rephrase based on review feedback
@loredanacirstea @Arachnid I've incorporated your feedback in the latest commit. Could you please 👍 if it looks good to you? Thank you! |
@MadeofTin another edit based on your feedback, re: "community interest" not block for Draft, but potentially blocking afterwards. While "community interest" will not be a factor in deciding whether an EIP gets merged as a draft, insufficient community interest may prevent your EIP from moving forward, especially if it is a Core EIP. |
@kriszrtina I removed that sentence in favor of @loredanacirstea, which I felt better phrased the same sentiment:
|
I'm merging this because three editors have approved, it has been discussed at ACD a few times and it documents the current process. Without judging the current process, at least having it well documented is a good starting point to change it. It is clear what is being changed. |
* Update eip-1.md * Update EIPS/eip-1.md Co-Authored-By: timbeiko <t.beiko23@gmail.com> * Update EIP-1 based on reviewer feedback * Remove qualifiers Based on @carver's comments. * Rephrase based on review feedback Rephrase based on review feedback
* Update eip-1.md * Update EIPS/eip-1.md Co-Authored-By: timbeiko <t.beiko23@gmail.com> * Update EIP-1 based on reviewer feedback * Remove qualifiers Based on @carver's comments. * Rephrase based on review feedback Rephrase based on review feedback
* Update eip-1.md * Update EIPS/eip-1.md Co-Authored-By: timbeiko <t.beiko23@gmail.com> * Update EIP-1 based on reviewer feedback * Remove qualifiers Based on @carver's comments. * Rephrase based on review feedback Rephrase based on review feedback
* Update eip-1.md * Update EIPS/eip-1.md Co-Authored-By: timbeiko <t.beiko23@gmail.com> * Update EIP-1 based on reviewer feedback * Remove qualifiers Based on @carver's comments. * Rephrase based on review feedback Rephrase based on review feedback
This PR serves as a replacement for #1932.
The Ethereum Cat Herders have been trying to improve the legibility of the EIP process within Ethereum. In order to minimize the amount of resources to be maintained, this PR expands some of the EIP championing sections of EIP-1. The contents of the page are inspired by this Ethereum Magicians thread, specifically @bmann's blog post and this tweetstorm.
Feedback welcome 😁