Updates Petersburg block number for Rinkeby #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evertonfraga
changed the title
|
I was actually wondering about before the last ACD, glad that someone fixed it! 😉 Also confirmed by this. |
axic
approved these changes
Nov 4, 2019
|
thanks for the fast response, Alex! :) |
ilanolkies
pushed a commit
to ilanolkies/EIPs
that referenced
this pull request
Nov 12, 2019
MadeofTin
pushed a commit
to MadeofTin/EIPs
that referenced
this pull request
Nov 13, 2019
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see that the EIP is finalized for a while, but the block number for Rinkeby is plain wrong. Block 9,999,999 would be created in two years from now.
For historical reasons, we should fix it to the block number 4,321,234, set by geth 1.8.24.
@5chdn @MariusVanDerWijden @karalabe