Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Adding Petersburg and Constantinople fork blocks to Rinkeby #71

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

evertonfraga
Copy link
Contributor

@evertonfraga evertonfraga commented Nov 4, 2019

The table below shows evidence of the fork numbers.

block date name
3,660,663 jan-2019 Constantinople
4,321,234 may-2019 Petersburg

Note 1: EIP 1716 mistakenly says Petersburg would activate in block 9,999,999 (in two years from now). I sent a PR aiming to correct it to the block number 4,321,234, introduced by Geth 1.8.24.

Note 2: Istanbul block number is taken care by PR #68.

@evertonfraga
Copy link
Contributor Author

EIP 1716 fix got merged: ethereum/EIPs#2352 (comment)

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@holgerd77 holgerd77 merged commit 3f244ae into ethereumjs:master Nov 5, 2019
@evertonfraga evertonfraga deleted the rinkeby-fork-blocks branch November 5, 2019 15:53
@evertonfraga
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants