-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-2098 stagnant (2021-Dec-26th@01.13.15) #4604
EIP-2098 stagnant (2021-Dec-26th@01.13.15) #4604
Conversation
I will move this to Final Call then if there are no objections? |
I believe if you get a PR out and merged, the bot will auto-close this? cc @alita-moore to verify if that is implemented or not. If the bot doesn't close it, just mention me and I will once you have a PR merged to move this to Last Call. |
Yes that's the case. It will close it as well if the pr is opened against the eip |
Opened #4611 to close this. Thanks! :) |
The bot seems to still be trying to stagnant-ify my EIP (#4620). I have a PR to move it to final call waiting for approval. |
That wasn't the bot, that was a spammer/scammer. They try to avoid detection by creating "realistic" looking PRs by just taking existing PRs and automatically recreating them. |
@MicahZoltu Oh, thanks for the info. Bots be crazy. :) |
@MicahZoltu Was this moved to stagnant by a bot? Or another scam imposter bot? |
@alita-moore Hmm, I thought once a PR was open against an EIP the bot would close the move to stagnant? |
@MicahZoltu looks like a bug. I'll take a look. |
This reverts commit 812866c.
Sorry @ricmoo. Just update your PR to move out of stagnant. Hopefully we can get the bug fixed so this doesn't happen in the future. |
I've updated #4611 . Thanks! :) |
PR 4604 with changes to EIPS/eip-2098.md was created on (2021-Dec-26th@01.13.18) which is before the cutoff date of (2021-Dec-26th@01.14.19) i.e. 2 weeks ago
…m#4604)" (ethereum#4659) This reverts commit 812866c.
This EIP has not been active since (2021-Jun-23rd@16.52.40); which, is greater than the allowed time of 6 months.
authors: @ricmoo, nick@ethereum.org