Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-2098 stagnant (2021-Dec-26th@01.13.15) #4604

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

eth-bot
Copy link
Collaborator

@eth-bot eth-bot commented Dec 26, 2021

This EIP has not been active since (2021-Jun-23rd@16.52.40); which, is greater than the allowed time of 6 months.

authors: @ricmoo, nick@ethereum.org

@eth-bot eth-bot marked this pull request as ready for review December 26, 2021 01:13
@ricmoo
Copy link
Contributor

ricmoo commented Dec 26, 2021

I will move this to Final Call then if there are no objections?

@MicahZoltu
Copy link
Contributor

I believe if you get a PR out and merged, the bot will auto-close this? cc @alita-moore to verify if that is implemented or not. If the bot doesn't close it, just mention me and I will once you have a PR merged to move this to Last Call.

@alita-moore
Copy link
Contributor

Yes that's the case. It will close it as well if the pr is opened against the eip

@ricmoo
Copy link
Contributor

ricmoo commented Dec 27, 2021

Opened #4611 to close this. Thanks! :)

@ricmoo
Copy link
Contributor

ricmoo commented Jan 1, 2022

The bot seems to still be trying to stagnant-ify my EIP (#4620). I have a PR to move it to final call waiting for approval.

@MicahZoltu
Copy link
Contributor

MicahZoltu commented Jan 2, 2022

The bot seems to still be trying to stagnant-ify my EIP (#4620). I have a PR to move it to final call waiting for approval.

That wasn't the bot, that was a spammer/scammer. They try to avoid detection by creating "realistic" looking PRs by just taking existing PRs and automatically recreating them.

@ricmoo
Copy link
Contributor

ricmoo commented Jan 2, 2022

@MicahZoltu Oh, thanks for the info. Bots be crazy. :)

@eth-bot eth-bot merged commit 812866c into master Jan 9, 2022
@eth-bot eth-bot deleted the mark-eip-2098-stagnant-(2021-Dec-26th@01.13.15) branch January 9, 2022 01:14
@ricmoo
Copy link
Contributor

ricmoo commented Jan 9, 2022

@MicahZoltu Was this moved to stagnant by a bot? Or another scam imposter bot?

@MicahZoltu
Copy link
Contributor

@alita-moore Hmm, I thought once a PR was open against an EIP the bot would close the move to stagnant?

@alita-moore
Copy link
Contributor

@MicahZoltu looks like a bug. I'll take a look.

@MicahZoltu
Copy link
Contributor

Sorry @ricmoo. Just update your PR to move out of stagnant. Hopefully we can get the bug fixed so this doesn't happen in the future.

@ricmoo
Copy link
Contributor

ricmoo commented Jan 21, 2022

I've updated #4611 . Thanks! :)

PhABC pushed a commit to PhABC/EIPs that referenced this pull request Jan 25, 2022
PR 4604 with changes to EIPS/eip-2098.md was created on 
	(2021-Dec-26th@01.13.18)
which is before the cutoff date of 
	(2021-Dec-26th@01.14.19)
i.e. 2 weeks ago
PhABC pushed a commit to PhABC/EIPs that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants