Move EIP-2098 to final call #4611
Merged
+9
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passed; auto-merging...(pass) eip-2098.md
|
poojaranjan
reviewed
Jan 4, 2022
lightclient
requested changes
Jan 5, 2022
There was a problem hiding this comment.
s/Test Vectors/Test CasesGas Analysisis not a valid##section per EIP-1, please include that information in one of the other sections.Rationaleseems like the best choice?s/Implementations/Reference ImplementationAcknowledgmentsis not a valid EIP section, please removeSecurity Considerationsis missing
Pencab
approved these changes
Jan 8, 2022
|
These changes have been made. |
MicahZoltu
reviewed
Jan 23, 2022
Co-authored-by: Micah Zoltu <micah@zoltu.net>
lightclient
requested changes
Feb 4, 2022
lightclient
approved these changes
Feb 4, 2022
PowerStream3604
pushed a commit
to PowerStream3604/EIPs
that referenced
this pull request
May 19, 2022
* Updated EIP-2098 compact representation with suggestions and moved to review. * Move EIP-2098 to final call. * Updated EIP-2098 as per request. * Update EIPS/eip-2098.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update EIPS/eip-2098.md Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving EIP-2098 to final call.