Revamp github issue/PR config #5066

Pandapip1 · 2022-05-01T16:41:52Z

See https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser for syntax.

Hopefully, this will result in more EIP working papers being sent to Ethereum Magicians, discussions-to links being created on Ethereum Magicians, EIP-Bot, and eipv issues being reported in the correct repository.

I have tentatively put the EIPIP repo as the place to submit suggestions related to the EIP process. EIP editors, feel free to suggest otherwise.

eth-bot · 2022-05-01T16:42:28Z

All tests passed; auto-merging...

(pass) .github/CONTRIBUTING.md

classification
`ambiguous`

file .github/CONTRIBUTING.md is not a valid filename, but this error has been ignored due to editor approvals

(pass) .github/ISSUE_TEMPLATE.md

classification
`ambiguous`

file .github/ISSUE_TEMPLATE.md is not a valid filename, but this error has been ignored due to editor approvals

(pass) .github/ISSUE_TEMPLATE/config.yml

classification
`ambiguous`

file .github/ISSUE_TEMPLATE/config.yml is not a valid filename, but this error has been ignored due to editor approvals

(pass) .github/ISSUE_TEMPLATE/propose-process-change.md

classification
`ambiguous`

file .github/ISSUE_TEMPLATE/propose-process-change.md is not a valid filename, but this error has been ignored due to editor approvals

(pass) .github/PULL_REQUEST_TEMPLATE.md

classification
`ambiguous`

file .github/PULL_REQUEST_TEMPLATE.md is not a valid filename, but this error has been ignored due to editor approvals

MicahZoltu · 2022-05-04T14:55:39Z

Do you have an example of what this will look like?

Pandapip1 · 2022-05-04T16:14:40Z

Hold on. I'll stick the file in the main branch of my fork (which I use for testing how GitHub reacts to changes like this).

EDIT: Apparently, as configured, it gets rid of the issues tab. I need to find out what causes that so I can fix it, as that is unintentional.

EDIT 2: Apparently I had disabled the issues feature on my fork. Oops.

Pandapip1 · 2022-05-04T16:23:27Z

Here's a preview: https://github.com/Pandapip1/EIPs/issues/new/choose

Pandapip1 · 2022-05-05T15:42:06Z

While we're at it, should I move the PR and issue template out of the root of the repository into the .github folder?

EDIT: I'll just repurpose the PR to do some general cleaning up / improvement of the issue and PR configs

.github/ISSUE_TEMPLATE/config.yml

MicahZoltu · 2022-05-06T09:18:54Z

Thanks for the example, I like this idea generally. I left some suggestions for reframing the titles into questions, curious how others feel. Also, the last one should probably be an issue here. We historically haven't used EIPIP repository for discussion about changes to the EIP process, we use EIPIP issues for discussion about changes to the EIPIP process. 😆

Co-authored-by: Micah Zoltu <micah@zoltu.net>

MicahZoltu · 2022-05-07T04:40:18Z

I approve, but want to wait to merge until some other editors have spoken up.

Pandapip1 · 2022-05-13T11:47:29Z

Since no EIP editors have responded yet, I'll CC them: @lightclient @axic @SamWilsn @gcolvin

.github/CONTRIBUTING.md

SamWilsn · 2022-05-13T19:52:16Z

Did you remove the option to submit an improvement for the EIP process? I feel like that's supposed to point to https://github.com/ethereum/EIPs/issues/new

Besides that, I love this idea.

gcolvin · 2022-05-13T20:00:18Z

Looks good to me. Thanks!

Pandapip1 · 2022-05-13T20:05:37Z

Did you remove the option to submit an improvement for the EIP process? I feel like that's supposed to point to https://github.com/ethereum/EIPs/issues/new

The main and the patch-8 branches are desynced. I'll re-sync them now.

Pandapip1 · 2022-05-27T14:11:29Z

Sorry for the late response. I've switched the default branch of Pandapip1/EIPs to patch-8, so https://github.com/Pandapip1/EIPs/issues/new/choose will be up to date.

MicahZoltu · 2022-05-28T04:50:30Z

Sam's most recent comment still seems pertinent after you fixed the desync. I don't see an option for "Do you want to propose a change to the EIP process itself?" in the list (which should direct the user to creating a new blank issue).

…to propose-process-change.md

Update issue templates

Pandapip1 · 2022-05-31T12:00:31Z

Sam's most recent comment still seems pertinent after you fixed the desync. I don't see an option for "Do you want to propose a change to the EIP process itself?" in the list (which should direct the user to creating a new blank issue).

Fixed.

.github/ISSUE_TEMPLATE/propose-process-change.md

* Create template for ERC4825 * It's 4829 apparently * Forgot that field was there * Undo all changes in _config.yml * Rename LICENSE to LICENSE.md * Test: add preamble * Propose contact links to reduce the number of issues made in error * Create config.yml * Revamp some configstuff * Few more changes I'm testing * Undo that merge * This is surprisingly annoying * I'll just keep it this way * Rephrase Ethereum Magicians Co-authored-by: Micah Zoltu <micah@zoltu.net> * Rephrase EIP Bot issues Co-authored-by: Micah Zoltu <micah@zoltu.net> * Rephrase eipv issues Co-authored-by: Micah Zoltu <micah@zoltu.net> * Remove eipip link * Replace w/ absolute link * Update issue templates * Rename do-you-want-to-propose-a-change-to-the-eip-process-itself-.md to propose-process-change.md * Delete custom.md Co-authored-by: Micah Zoltu <micah@zoltu.net>

ghost

#6958

Merged by EIP-Bot.

Pandapip1 added 7 commits March 31, 2022 15:20

Create template for ERC4825

4c67c7e

It's 4829 apparently

79ebdf7

Forgot that field was there

30d1cd6

Undo all changes in _config.yml

1cff39b

Rename LICENSE to LICENSE.md

d5e01fc

Test: add preamble

2591308

Propose contact links to reduce the number of issues made in error

0693101

eth-bot added the ambiguous label May 1, 2022

Pandapip1 mentioned this pull request May 1, 2022

EIPIP Meeting 55 Agenda ethcatherders/EIPIP#130

Closed

Create config.yml

685b210

Pandapip1 changed the title ~~Propose contact links to reduce the number of issues made in error~~ Revamp github issue/PR config May 5, 2022

Pandapip1 and others added 6 commits May 5, 2022 16:47

Revamp some configstuff

947e8fe

Merge branch 'master' into patch-8

22c1222

Few more changes I'm testing

1bff624

Undo that merge

b40d1cc

This is surprisingly annoying

c171b83

I'll just keep it this way

64aad5e

MicahZoltu reviewed May 6, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved

MicahZoltu reviewed May 6, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved

MicahZoltu reviewed May 6, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved

MicahZoltu reviewed May 6, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved

Pandapip1 and others added 3 commits May 6, 2022 07:36

Rephrase Ethereum Magicians

f36f4b1

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Rephrase EIP Bot issues

c15760f

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Rephrase eipv issues

b5e92af

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Remove eipip link

3c600b4

SamWilsn reviewed May 13, 2022

View reviewed changes

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved

Replace w/ absolute link

f3389b7

Pandapip1 requested a review from MicahZoltu May 27, 2022 14:18

Pandapip1 added 4 commits May 31, 2022 07:48

Update issue templates

e167152

Rename do-you-want-to-propose-a-change-to-the-eip-process-itself-.md …

b26c5cf

…to propose-process-change.md

Merge pull request #5 from Pandapip1/Pandapip1-patch-1

15510a2

Update issue templates

Delete custom.md

a7d728c

MicahZoltu reviewed May 31, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/propose-process-change.md Show resolved Hide resolved

MicahZoltu approved these changes Jun 1, 2022

View reviewed changes

MicahZoltu closed this Jun 1, 2022

MicahZoltu reopened this Jun 1, 2022

eth-bot enabled auto-merge (squash) June 1, 2022 07:10

eth-bot merged commit 11b3678 into ethereum:master Jun 1, 2022

Pandapip1 mentioned this pull request Jun 1, 2022

Remove greeting bot #5124

Merged

This comment was marked as spam.

Sign in to view

ghost reviewed Apr 30, 2023

View reviewed changes

ghost referenced this pull request Apr 30, 2023

Update EIP-5656: Fix typos

c2d1a03

Merged by EIP-Bot.

ghost referenced this pull request Apr 30, 2023

Update EIP-6404: Add 0x01 prefix for Some

eeb03f7

Merged by EIP-Bot.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revamp github issue/PR config #5066

Revamp github issue/PR config #5066

Pandapip1 commented May 1, 2022

eth-bot commented May 1, 2022 •

edited

Loading

MicahZoltu commented May 4, 2022

Pandapip1 commented May 4, 2022 •

edited

Loading

Pandapip1 commented May 4, 2022

Pandapip1 commented May 5, 2022 •

edited

Loading

MicahZoltu commented May 6, 2022

MicahZoltu commented May 7, 2022

Pandapip1 commented May 13, 2022 •

edited

Loading

SamWilsn commented May 13, 2022 •

edited

Loading

gcolvin commented May 13, 2022

Pandapip1 commented May 13, 2022

Pandapip1 commented May 27, 2022

MicahZoltu commented May 28, 2022

Pandapip1 commented May 31, 2022

This comment was marked as spam.

ghost left a comment

Revamp github issue/PR config #5066

Revamp github issue/PR config #5066

Conversation

Pandapip1 commented May 1, 2022

eth-bot commented May 1, 2022 • edited Loading

All tests passed; auto-merging...

(pass) .github/CONTRIBUTING.md

(pass) .github/ISSUE_TEMPLATE.md

(pass) .github/ISSUE_TEMPLATE/config.yml

(pass) .github/ISSUE_TEMPLATE/propose-process-change.md

(pass) .github/PULL_REQUEST_TEMPLATE.md

MicahZoltu commented May 4, 2022

Pandapip1 commented May 4, 2022 • edited Loading

Pandapip1 commented May 4, 2022

Pandapip1 commented May 5, 2022 • edited Loading

MicahZoltu commented May 6, 2022

MicahZoltu commented May 7, 2022

Pandapip1 commented May 13, 2022 • edited Loading

SamWilsn commented May 13, 2022 • edited Loading

gcolvin commented May 13, 2022

Pandapip1 commented May 13, 2022

Pandapip1 commented May 27, 2022

MicahZoltu commented May 28, 2022

Pandapip1 commented May 31, 2022

This comment was marked as spam.

ghost left a comment

Choose a reason for hiding this comment

eth-bot commented May 1, 2022 •

edited

Loading

Pandapip1 commented May 4, 2022 •

edited

Loading

Pandapip1 commented May 5, 2022 •

edited

Loading

Pandapip1 commented May 13, 2022 •

edited

Loading

SamWilsn commented May 13, 2022 •

edited

Loading