Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove greeting bot #5124

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Remove greeting bot #5124

merged 1 commit into from
Jun 29, 2022

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Jun 1, 2022

Rationale: With #5066 merged, users should be more aware of the information given in the greeting bot - and at this point, the greeting bot seems to cause more annoyances than benefits. I suggest it be removed.

@eth-bot will not merge this. It will need to be manually merged.

@eth-bot
Copy link
Collaborator

eth-bot commented Jun 1, 2022

A critical and unhandled exception has occurred:
Message: not found
Data: (there is no data for this error)(cc @alita-moore, @mryalamanchi)

@Pandapip1
Copy link
Member Author

Editor CC since @eth-bot didn't ping: @MicahZoltu @lightclient @gcolvin @axic @SamWilsn

@SamWilsn
Copy link
Contributor

SamWilsn commented Jun 3, 2022

I can't override the bot, sorry ^^;;

@MicahZoltu
Copy link
Contributor

Given the changes in #5066, I'm open to giving things a try without the greeter to see if it would still add value or not. I'll wait to hear from other editors before merging though.

@Pandapip1
Copy link
Member Author

Re-mentioning editors that have not responded: @lightclient @gcolvin @axic

@Pandapip1
Copy link
Member Author

It's been a week since there's been discussion on this. @MicahZoltu would you mind merging this for now? It can always be reverted.

@axic
Copy link
Member

axic commented Jun 14, 2022

Can someone TLDR this entire convo for me? What is wrong with the greeter?

@gcolvin
Copy link
Contributor

gcolvin commented Jun 14, 2022

Can someone TLDR this entire convo for me? What is wrong with the greeter?

The only complaints I'm hearing is that it is verbose and redundant.

In which case make it less so, but even I find the reminders useful. What is right about the greeter for me is that it mentions me as an editor only for core EIPs. That makes it possible to get notifications for those PRs without being flooded with ERCs. Those mentions might also help authors know who to go hassle if their work isn't getting reviewed ;)

@Pandapip1
Copy link
Member Author

Pandapip1 commented Jun 14, 2022

Sorry for the confusion. This is specifically the @github-actions bot that comments on new issues reminding users to check out EIP-1 (this comment). This is redundant now that users are informed about the correct place to post things before creating an issue.

The @eth-bot PR greeter/auto merger is a totally separate system and is, indeed, extremely useful.

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay with me. Will wait to see if there is any other feedback.

@MicahZoltu
Copy link
Contributor

@axic There was a recent change to the issue creation flow that should (hopefully) serve the same purpose as the greeter bot but before the user creates the issue, rather than after. This PR proposes to remove the greeter since it is functionally redundant. If you want to see the new issue flow, just click the new issue button in GitHub.

@Pandapip1
Copy link
Member Author

Bump.

@lightclient
Copy link
Member

I think we can move forward with this as there has been no other feedback. @Pandapip1 or @MicahZoltu, I think if you approve it will automatically merge.

@MicahZoltu MicahZoltu merged commit 48667fe into ethereum:master Jun 29, 2022
@Pandapip1 Pandapip1 deleted the patch-14 branch June 29, 2022 19:08
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants