-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove greeting bot #5124
Remove greeting bot #5124
Conversation
A critical and unhandled exception has occurred: |
Editor CC since @eth-bot didn't ping: @MicahZoltu @lightclient @gcolvin @axic @SamWilsn |
I can't override the bot, sorry ^^;; |
Given the changes in #5066, I'm open to giving things a try without the greeter to see if it would still add value or not. I'll wait to hear from other editors before merging though. |
Re-mentioning editors that have not responded: @lightclient @gcolvin @axic |
It's been a week since there's been discussion on this. @MicahZoltu would you mind merging this for now? It can always be reverted. |
Can someone TLDR this entire convo for me? What is wrong with the greeter? |
The only complaints I'm hearing is that it is verbose and redundant. In which case make it less so, but even I find the reminders useful. What is right about the greeter for me is that it mentions me as an editor only for core EIPs. That makes it possible to get notifications for those PRs without being flooded with ERCs. Those mentions might also help authors know who to go hassle if their work isn't getting reviewed ;) |
Sorry for the confusion. This is specifically the @github-actions bot that comments on new issues reminding users to check out EIP-1 (this comment). This is redundant now that users are informed about the correct place to post things before creating an issue. The @eth-bot PR greeter/auto merger is a totally separate system and is, indeed, extremely useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay with me. Will wait to see if there is any other feedback.
@axic There was a recent change to the issue creation flow that should (hopefully) serve the same purpose as the greeter bot but before the user creates the issue, rather than after. This PR proposes to remove the greeter since it is functionally redundant. If you want to see the new issue flow, just click the new issue button in GitHub. |
Bump. |
I think we can move forward with this as there has been no other feedback. @Pandapip1 or @MicahZoltu, I think if you approve it will automatically merge. |
Rationale: With #5066 merged, users should be more aware of the information given in the greeting bot - and at this point, the greeting bot seems to cause more annoyances than benefits. I suggest it be removed.
@eth-bot will not merge this. It will need to be manually merged.