Update EIP-4844: change op to BLOBHASH
#7001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
BLOBHASHBLOBHASH
chfast
reviewed
May 9, 2023
EIPS/eip-4844.md
Outdated
| @@ -246,7 +246,7 @@ The `ethereum/consensus-specs` repository defines the following beacon-node chan | |||
|
|
|||
| ### Opcode to get versioned hashes | |||
|
|
|||
| We add an opcode `DATAHASH` (with byte value `HASH_OPCODE_BYTE`) which reads `index` from the top of the stack | |||
| We add an opcode `BLOBHASH` (with byte value `HASH_OPCODE_BYTE`) which reads `index` from the top of the stack | |||
There was a problem hiding this comment.
Suggested change
| We add an opcode `BLOBHASH` (with byte value `HASH_OPCODE_BYTE`) which reads `index` from the top of the stack | |
| We add an instruction `BLOBHASH` (with opcode `HASH_OPCODE_BYTE`) which reads `index` from the top of the stack |
There was a problem hiding this comment.
Some other name suggestions were:
TXBLOBHASHTXDATAHASH
|
If we go forward with this, we should consider changing the nomenclature in the EIP generally to use "blob" instead of "data". |
|
Makes sense as we already call the hashes in the blob tx |
dankrad
previously approved these changes
May 16, 2023
|
@dankrad also already approved this but the review was dismissed due to a rebase. The change is still the exact same, so I will go ahead and merge. |
eth-bot
approved these changes
May 16, 2023
AskAlexSharov
pushed a commit
to erigontech/erigon
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
DATAHASHsort of conflicts with the EOF data section concept (which will want to have things likeDATALOAD,DATACOPY, etc for). So I propose we change the mnemonic for blob hashes toBLOBHASHinstead.