Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm/common: rename DATAHASH to BLOBHASH #2711

Merged
merged 1 commit into from
May 17, 2023
Merged

evm/common: rename DATAHASH to BLOBHASH #2711

merged 1 commit into from
May 17, 2023

Conversation

jochem-brouwer
Copy link
Member

@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #2711 (1a5fca5) into master (3498ce9) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.70% <ø> (ø)
blockchain 90.72% <ø> (ø)
client 86.97% <ø> (ø)
common 97.05% <ø> (ø)
devp2p 89.14% <ø> (-0.34%) ⬇️
ethash ∅ <ø> (∅)
evm 79.38% <100.00%> (ø)
rlp ∅ <ø> (∅)
statemanager 80.92% <ø> (ø)
trie 89.94% <ø> (ø)
tx 96.01% <ø> (ø)
util 81.34% <ø> (ø)
vm 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

acolytec3
acolytec3 approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jochem-brouwer
Copy link
Member Author

Thanks, will merge 😄

@jochem-brouwer jochem-brouwer merged commit e75ebc2 into master May 17, 2023
@holgerd77 holgerd77 deleted the update-datahash-blobhash branch May 17, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: common package: evm PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jochem-brouwer @acolytec3