-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-4844: Increase Blob Throughput #7154
Conversation
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I think we should move ahead w/ this change on 4844 devnets and can always dial it back down if needed
| `MAX_DATA_GAS_PER_BLOCK` | `786432` | | ||
| `TARGET_DATA_GAS_PER_BLOCK` | `393216` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking math:
2^18 works out to 2 blobs (4096 * 32 bytes per blob given trusted setup size)
2^19 works out to 4 blobs (max is double target)
if we increase target by 50% (to move from 2 to 3), then we in fact get the numbers proposed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider 3 * 2**18
and 3 * 2**17
for legibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could add in the third column (so after the decimal representations), I do like having the multiplier * base factor representation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem is that this depends on the specific context, e.g. not obvious why it always should be base 2. or also, might be better in this specific case to always use factor * 2**17 (so that factor would be the number of blobs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you go with partially calculated values, here another option (clearer imho):
3 * DATA_GAS_PER_BLOB
6 * DATA_GAS_PER_BLOB
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Increases the throughput to a target of 3 blobs (0.375MB) and limit of 6 blobs (0.75MB) as decided on ethereum/pm#786.
Also adjusts
DATA_GASPRICE_UPDATE_FRACTION
to keep targeting a max change rate for the blob gas price of 12.5% per block (see EIP section for math).