Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-627: fix typo #7956

Closed
wants to merge 8 commits into from
Closed

Update EIP-627: fix typo #7956

wants to merge 8 commits into from

Conversation

momodaka
Copy link
Contributor

@momodaka momodaka commented Nov 8, 2023

metainformation -> Meta-information
excuding -> excluding
possiblitity -> possibility

@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-networking labels Nov 8, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 8, 2023 •
edited
Loading

File EIPS/eip-627.md

Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Nov 8, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

The commit e47e3c5 (as a parent of c8a6570) contains errors.
Please inspect the Run Summary for details.

@g11tech
Copy link
Contributor

g11tech commented Nov 10, 2023

@momodaka unfortunately you might also need to fix some other linter rules to get this PR merge ready

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 10, 2023
@momodaka
Copy link
Contributor Author

all lint issue are fixed

g11tech
g11tech requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm there is an author change, so could you get the original author to approve the change

@poojaranjan poojaranjan mentioned this pull request Dec 12, 2023
Closed
11 tasks
@poojaranjan poojaranjan mentioned this pull request Apr 16, 2024
Closed
19 tasks
@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Apr 19, 2024
@SamWilsn
Copy link
Contributor

Since this is a Final EIP, and this is changing more than typos, @lightclient and I feel we should close this without merging.

@SamWilsn SamWilsn closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech requested changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-networking w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@momodaka @eth-bot @g11tech @SamWilsn