Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-145: fix typo #7958

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Update EIP-145: fix typo #7958

merged 7 commits into from
Jan 3, 2024

Conversation

momodaka
Copy link
Contributor

@momodaka momodaka commented Nov 9, 2023

insturctions -> instructions

@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Nov 9, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 9, 2023 •
edited
Loading

🛑 Auto merge failed. Please see logs for more details, and report this issue at the eip-review-bot repository.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Nov 9, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 9, 2023
@g11tech
Copy link
Contributor

g11tech commented Nov 10, 2023

@momodaka unfortunately you might require to fix a bit more linter errors to get it to merge ready state

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 14, 2023
@momodaka
Copy link
Contributor Author

All fixable lint issues have been solved.
The "discussions-to" field lacks a forum discussion post.
External links were retained where essential information was present.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 14, 2023
@poojaranjan poojaranjan mentioned this pull request Dec 12, 2023
Closed
11 tasks
@poojaranjan poojaranjan mentioned this pull request Jan 3, 2024
Closed
7 tasks
@SamWilsn SamWilsn merged commit 2f574d0 into ethereum:master Jan 3, 2024
9 of 10 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

The commit 23a3d09 (as a parent of 5e7687a) contains errors.
Please inspect the Run Summary for details.

GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@momodaka @SamWilsn @GAEAlimited
Update EIP-145: fix typo (ethereum#7958)
1432fde 
* Update EIP-145: fix typo

* docs: fix lint issue

* docs: fix lint issue

* Update eip-145.md

---------

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
@momodaka @SamWilsn @blacksnow2
Update EIP-145: fix typo (ethereum#7958)
720d27f 
* Update EIP-145: fix typo

* docs: fix lint issue

* docs: fix lint issue

* Update eip-145.md

---------

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@chfast chfast chfast approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-core w-ci Waiting on CI to pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@momodaka @eth-bot @g11tech @chfast @SamWilsn