Update ERC-6492: add audit report and changes prompted by the audit #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File
|
|
The commit 369d39b (as a parent of 93664c8) contains errors. |
SamWilsn
requested changes
Feb 21, 2024
There was a problem hiding this comment.
This'll need to wait for a Call for Input: ethcatherders/EIPIP#321
There was a problem hiding this comment.
There is no copyright license information in this file. Please add a LICENSE file to your assets folder with the license this file is provided under. We generally prefer CC0-1.0, but would also accept MIT, Apache, or similar.
| @@ -243,6 +262,8 @@ However, deploying a contract requires a `CALL` rather than a `STATICCALL`, whic | |||
|
|
|||
| Furthermore, it is likely that this ERC will be more frequently used for off-chain validation, as in many cases, validating a signature on-chain presumes the wallet has been already deployed. | |||
|
|
|||
| **The reference implementation in this ERC has been audited:** look for `ERC6492-Hunter-Security-Audit-Report-v1.0.pdf` in the assets directory. | |||
There was a problem hiding this comment.
Suggested change
| **The reference implementation in this ERC has been audited:** look for `ERC6492-Hunter-Security-Audit-Report-v1.0.pdf` in the assets directory. | |
| **The reference implementation in this ERC has been audited:** look for [`ERC6492-Hunter-Security-Audit-Report-v1.0.pdf`](../assets/eip-6492/ERC6492-Hunter-Security-Audit-Report-v1.0.pdf) in the assets directory. |
|
As discussed in the previously mentioned Call for Input, I am closing this PR without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ERC-6492 was recently audited and a few non-critical issues were found, and as such it is strongly advised to change the reference implementation.
This PR does not change the ERC text itself in any way except adding a link to the audit. The ERC is final.