Add ERC: Temporary Approval Extension for ERC-20 #358

byshape · 2024-04-02T21:31:29Z

Among all cases of ERC-20 token transactions, a popular one is when smart contracts approve token spending to other contracts. Often tokens are approved for only one transaction.

Following the ERC-20 standard, if a smart contract wants to approve the spending of tokens to another smart contract for only one transaction, this causes the allowance saved in storage to be updated and retrieved.

Token allowances utilising EIP-1153 transient storage are a cheaper alternative to the regular storage allowances.

eip-review-bot · 2024-04-02T21:31:59Z

✅ All reviewers have approved.

ERCS/eip-draft-tae-erc20.md

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>

ZumZoom · 2024-04-03T11:23:42Z

Commit 85f7d71 removes EIP-1153 reference from the description section but it seems that EIP Walidator needs to be fixed instead:

https://github.com/ethereum/ERCs/actions/runs/8536634399/job/23385573486#step:3:14

Error: error[preamble-refs-description]: unable to read file ``erc-1153.md``: Io: JsValue(Error: ENOENT: no such file or directory, open 'ERCS/erc-1153.md'

It seems that it disallows referencing any EIP in the description section.

ERCS/erc-7674.md

Amxx · 2024-04-03T15:32:51Z

IMO "transient" is a technical name that refers to the underlying mechanism used here, but should not be exposed in the ABI or in the "docuementation" or this feature. I propose using "temporary allowance" instead of "transient allowance", as I believe this naming would be more user-friendly for people that have no knowledge of EIP-1153

Amxx · 2024-04-03T15:42:41Z

This ERC should clearly mention that:

No event is required when setting a temporary/transient allowance
This ERC does not break ERC20's transferFrom, because setting a temporary/transient allowance falls in the scope of "explicitelly authorizing the transfer"

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>

…ions

Amxx · 2024-06-06T14:47:12Z

@byshape created byshape#1 to update this PR. We should stry to get it merge sonner rather than latter.

Co-authored-by: Mikhail Melnik <by.zumzoom@gmail.com>

Update ERC-7674 based on PR comments

ERCS/erc-7674.md

SamWilsn · 2024-06-10T20:44:13Z

ERCS/erc-7674.md

+---
+eip: 7674
+title: Temporary Approval Extension for ERC-20
+description: An interface for ephemeral ERC-20 approvals


Suggested change

description: An interface for ephemeral ERC-20 approvals

description: An interface for ERC-20 approvals lasting a single transaction

SamWilsn · 2024-06-10T21:58:17Z

ERCS/erc-7674.md

+
+## Motivation
+
+User are often require to set token approval that will only be used once. It is common to leave unexpected approvals after these interactions. [EIP-1153](./eip-1153.md) introduces a cheap way to handle temporarily allowances.


will only be used once

This is a bit misleading. This approval can be used multiple times, as long as it's in a single transaction.

ERCS/erc-7674.md

github-actions · 2024-07-15T22:47:23Z

The commit 8a11a87 (as a parent of e167942) contains errors.
Please inspect the Run Summary for details.

SamWilsn · 2024-08-08T19:39:25Z

I took the liberty of fixing your EIP/ERC links. You do need to use [ERC-20](./eip-20.md) when linking to ERCs because of a quirk in our rendering system.

# Conflicts: # ERCS/erc-7674.md

Updated based on PR comments

eip-review-bot

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot

All Reviewers Have Approved; Performing Automatic Merge...

Add Transient Approval Extension for ERC-20

a7dffe7

byshape requested a review from eip-review-bot as a code owner April 2, 2024 21:31

github-actions bot added c-new s-draft t-erc labels Apr 2, 2024

eip-review-bot added the e-consensus label Apr 2, 2024

github-actions bot added the w-ci label Apr 2, 2024

Fixed EIP requirements

d7eefe8

abcoathup reviewed Apr 3, 2024

View reviewed changes

ERCS/eip-draft-tae-erc20.md Outdated Show resolved Hide resolved

abcoathup reviewed Apr 3, 2024

View reviewed changes

ERCS/eip-draft-tae-erc20.md Outdated Show resolved Hide resolved

byshape and others added 2 commits April 3, 2024 10:37

Update ERCS/eip-draft-tae-erc20.md

3eacea2

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>

Renamed file and added link to the discussion

11e2cce

eip-review-bot added the e-review label Apr 3, 2024

eip-review-bot changed the title ~~Add Transient Approval Extension for ERC-20~~ Add ERC: Transient Approval Extension for ERC-20 Apr 3, 2024

github-actions bot added w-ci and removed w-ci labels Apr 3, 2024

Fixed description

85f7d71

github-actions bot removed the w-ci label Apr 3, 2024

Updated authors

a0d173e

Amxx reviewed Apr 3, 2024

View reviewed changes

ERCS/erc-7674.md Outdated Show resolved Hide resolved

Amxx reviewed Apr 3, 2024

View reviewed changes

ERCS/erc-7674.md Outdated Show resolved Hide resolved

byshape and others added 4 commits April 4, 2024 18:28

Apply suggestions from code review

87ac36d

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>

Merge branch 'master' into transient-approve

5146bb9

Replaced transient => temporary

fba3948

Refined the Specification, Rationale and Backwards Compatibility sect…

c5e98c2

…ions

eip-review-bot changed the title ~~Add ERC: Transient Approval Extension for ERC-20~~ Add ERC: Temporary Approval Extension for ERC-20 Apr 4, 2024

update based on PR comments

d70eb46

Amxx and others added 2 commits June 10, 2024 15:40

Update ERCS/erc-7674.md

fe09677

Co-authored-by: Mikhail Melnik <by.zumzoom@gmail.com>

Merge pull request #1 from Amxx/transient-approve

9d5885a

Update ERC-7674 based on PR comments

frangio mentioned this pull request Jun 10, 2024

Add ERC7674 (draft) OpenZeppelin/openzeppelin-contracts#5071

Merged

5 tasks

github-actions bot added the w-ci label Jun 10, 2024

Update based on PR comments

3c10621

github-actions bot removed the w-ci label Jun 10, 2024

frangio reviewed Jun 10, 2024

View reviewed changes

ERCS/erc-7674.md Outdated Show resolved Hide resolved

SamWilsn reviewed Jun 10, 2024

View reviewed changes

ZumZoom reviewed Jul 15, 2024

View reviewed changes

ERCS/erc-7674.md Show resolved Hide resolved

ERCS/erc-7674.md Show resolved Hide resolved

ERCS/erc-7674.md Outdated Show resolved Hide resolved

ERCS/erc-7674.md Show resolved Hide resolved

ERCS/erc-7674.md Outdated Show resolved Hide resolved

fix erc/eip links

1ce1aae

github-actions bot added the w-ci label Jul 15, 2024

byshape added 2 commits July 15, 2024 19:38

Merge branch 'master' into transient-approve

8a11a87

Updated based on PR comments

722f023

SamWilsn added 2 commits August 8, 2024 15:35

Update erc-7674.md: fix eip links

51b7148

Update erc-7674.md

b7978f8

github-actions bot removed the w-ci label Aug 8, 2024

byshape and others added 5 commits January 12, 2025 22:11

Merge branch 'transient-approve' into transient-approve-wip

b3456ce

# Conflicts: # ERCS/erc-7674.md

Merge pull request #2 from byshape/transient-approve-wip

6171b37

Updated based on PR comments

Merge branch 'master' into transient-approve

2ec28b5

Update erc-7674.md

7dd0208

Update erc-7674.md

31079e6

SamWilsn approved these changes Mar 6, 2025

View reviewed changes

eip-review-bot enabled auto-merge (squash) March 6, 2025 14:55

eip-review-bot approved these changes Mar 6, 2025

View reviewed changes

eip-review-bot merged commit 892a03d into ethereum:master Mar 6, 2025
10 of 12 checks passed

	description: An interface for ephemeral ERC-20 approvals
	description: An interface for ERC-20 approvals lasting a single transaction


		## Motivation

		User are often require to set token approval that will only be used once. It is common to leave unexpected approvals after these interactions. [EIP-1153](./eip-1153.md) introduces a cheap way to handle temporarily allowances.

Add ERC: Temporary Approval Extension for ERC-20 #358

Add ERC: Temporary Approval Extension for ERC-20 #358

Uh oh!

Conversation

byshape commented Apr 2, 2024

Uh oh!

eip-review-bot commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZumZoom commented Apr 3, 2024

Uh oh!

Uh oh!

Uh oh!

Amxx commented Apr 3, 2024

Uh oh!

Amxx commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Amxx commented Jun 6, 2024

Uh oh!

Uh oh!

SamWilsn Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

SamWilsn Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2024

Uh oh!

SamWilsn commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eip-review-bot left a comment

Choose a reason for hiding this comment

Uh oh!

eip-review-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

eip-review-bot commented Apr 2, 2024 •

edited

Loading

Amxx commented Apr 3, 2024 •

edited

Loading

SamWilsn commented Aug 8, 2024 •

edited

Loading