-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-1363: Move motivation and rationale to eip1 recommendation #74
Update ERC-1363: Move motivation and rationale to eip1 recommendation #74
Conversation
File
|
…ve-erc1363-to-eip1-recommendation-1step
…ve-erc1363-to-eip1-recommendation-1step
…ve-erc1363-to-eip1-recommendation-1step
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
…ve-erc1363-to-eip1-recommendation-1step
…ve-erc1363-to-eip1-recommendation-1step
The commit 20ee1ff (as a parent of 41a72a1) contains errors. |
These changes are a bit more involved than we allow for final EIPs. I think the best option would be to open a new EIP with the updated content. |
This PR is part of some changes I would like to make on ERC1363 to follow the modern EIP1 recommendation.
This PR:
Note that this PR will not pass the CI, because of many changes required by validator and that are not addressed here but will be addressed in other PR.
I.g. external links, broken link, new line after h1, etc.
Other PR will address other sections of ERC1363