Attestation changes + persistent committee changes #1294

vbuterin · 2019-07-13T08:07:56Z

Shard slots
Attestation list -> single attestation
One-day periods
Committee simplification

…huffling_seed

specs/core/1_shard-data-chains.md

djrtwo · 2019-07-23T13:57:09Z

@vbuterin Should this be reviewed, tests fixed, and merged?

protolambda · 2019-07-23T15:40:50Z

If we change PLACEHOLDER, we should also change the other PLACEHOLDER in custody spec, or rename this one to something more specific.

dankrad · 2019-07-23T16:29:10Z

Is there a discussion on why we want to change it to one day? Isn't that worse for light clients?

…ink structure

vbuterin · 2019-07-24T12:09:35Z

Is there a discussion on why we want to change it to one day? Isn't that worse for light clients?

See the "implementation alternative" section here #1293

The shard period (I'm proposing to rename "persistent committee period" to "shard period" because the former is waaaay too long) goes down to 1 day, but the committee size drops to 128, so on net it's still a savings for light clients.

specs/core/1_shard-data-chains.md

djrtwo · 2019-07-24T17:50:42Z

specs/core/1_shard-data-chains.md


 ```python
-class ShardBlockHeader(Container):
-    slot: Slot
-    shard: Shard


I think we are losing value by removing shard here by not being able to immediately recognize a shard block as being from a particular shard and instead just understanding it in the context of it's parent and the state (that must be calculated) related to the state_root.

We still have 80 bytes to play with in ShardBlockCore now that we have divided it into two 256-byte halves

I can see that; I'd be ok with putting it back in (though we'd have to take it back out if we decide we want to add another slot as then we would exceed 8; or we could add slot offsets for different shards 😄)

specs/core/1_shard-data-chains.md

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

protolambda · 2019-07-24T19:13:59Z

specs/core/1_shard-data-chains.md

@@ -75,207 +91,191 @@ The following types are defined, mapping into `DomainType` (little endian):

 | Name | Value |
 | - | - |
-| `PLACEHOLDER` | `2**32` |
+| `PLACEHOLDER` | `2**3` |


Suggested change

| `PLACEHOLDER` | `2**3` |

And the whole ### TODO PLACEHOLDER section.

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

specs/core/1_shard-data-chains.md

hwwhww · 2019-07-25T06:39:53Z

specs/core/1_shard-data-chains.md

@@ -75,207 +91,191 @@ The following types are defined, mapping into `DomainType` (little endian):

 | Name | Value |
 | - | - |
-| `PLACEHOLDER` | `2**32` |
+| `PLACEHOLDER` | `2**3` |


And the whole ### TODO PLACEHOLDER section.

specs/core/1_shard-data-chains.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

djrtwo

Needs more testing but we'll add that in iterative testing PRs

* Minimal attestation simplification * minor fix * Make the tests pass * Decrease `PLACEHOLDER`, Use `compute_epoch_of_shard_slot` * Fix proposer signature name and use get_seed() to calculate current_shuffling_seed * Fix linter error * Add the WIP `test_is_valid_shard_block` * Add `get_shard_block_attester_committee` * Simplified committee selection * Added some helpers and simplified * Update specs/core/1_shard-data-chains.md * Update 1_shard-data-chains.md * Simplified switchover epochs, changed block structure, changed crosslink structure * Update 1_shard-data-chains.md * Moved balance dependency to proposer selection * Update specs/core/1_shard-data-chains.md Co-Authored-By: Danny Ryan <dannyjryan@gmail.com> * Update specs/core/1_shard-data-chains.md Co-Authored-By: Danny Ryan <dannyjryan@gmail.com> * Update specs/core/1_shard-data-chains.md Co-Authored-By: Danny Ryan <dannyjryan@gmail.com> * Update specs/core/1_shard-data-chains.md Co-Authored-By: Danny Ryan <dannyjryan@gmail.com> * Update specs/core/1_shard-data-chains.md Co-Authored-By: Danny Ryan <dannyjryan@gmail.com> * Update specs/core/1_shard-data-chains.md Co-Authored-By: Danny Ryan <dannyjryan@gmail.com> * Update specs/core/1_shard-data-chains.md Co-Authored-By: Danny Ryan <dannyjryan@gmail.com> * Update specs/core/1_shard-data-chains.md * Fixed shard header flattening * Update specs/core/1_shard-data-chains.md * Minor fixes * Update specs/core/1_shard-data-chains.md * Update specs/core/1_shard-data-chains.md Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com> * cleanup testing and lint * return none if not active validators in persistent committee * only allow active validators as shard proposer

Minimal attestation simplification

99a5060

vbuterin mentioned this pull request Jul 13, 2019

Phase 1 shard blocks checklist #1211

Closed

10 tasks

hwwhww added the phase1 label Jul 15, 2019

hwwhww added 6 commits July 15, 2019 15:52

minor fix

14010f5

Make the tests pass

0cfca01

Decrease PLACEHOLDER, Use compute_epoch_of_shard_slot

f77df3f

Fix proposer signature name and use get_seed() to calculate current_s…

bcfff59

…huffling_seed

Fix linter error

be1bc52

Add the WIP test_is_valid_shard_block

7ca5031

djrtwo reviewed Jul 15, 2019

View reviewed changes

specs/core/1_shard-data-chains.md Outdated Show resolved Hide resolved

hwwhww and others added 3 commits July 16, 2019 13:50

Add get_shard_block_attester_committee

ac29581

Simplified committee selection

2b2b143

Added some helpers and simplified

b5de66a

vbuterin changed the title ~~Minimal attestation simplification~~ Attestation changes + persistent committee changes Jul 19, 2019

vbuterin commented Jul 19, 2019

View reviewed changes

specs/core/1_shard-data-chains.md Outdated Show resolved Hide resolved

vbuterin and others added 3 commits July 19, 2019 12:13

Update specs/core/1_shard-data-chains.md

8611f91

Update 1_shard-data-chains.md

eb03f03

Merge branch 'dev' into vitalik88

1bc65ca

Simplified switchover epochs, changed block structure, changed crossl…

8f0ad70

…ink structure

vbuterin commented Jul 24, 2019

View reviewed changes

specs/core/1_shard-data-chains.md Outdated Show resolved Hide resolved

vbuterin commented Jul 24, 2019

View reviewed changes

specs/core/1_shard-data-chains.md Outdated Show resolved Hide resolved

vbuterin added 2 commits July 24, 2019 09:29

Update 1_shard-data-chains.md

6812e46

Moved balance dependency to proposer selection

827b181

djrtwo reviewed Jul 24, 2019

View reviewed changes

vbuterin and others added 2 commits July 24, 2019 15:13

Update specs/core/1_shard-data-chains.md

96b3cb9

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

Update specs/core/1_shard-data-chains.md

d33ee7c

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

protolambda reviewed Jul 24, 2019

View reviewed changes

vbuterin and others added 5 commits July 24, 2019 15:16

Update specs/core/1_shard-data-chains.md

b859b26

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

Update specs/core/1_shard-data-chains.md

8299399

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

Update specs/core/1_shard-data-chains.md

2af058f

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

Update specs/core/1_shard-data-chains.md

4951768

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

Update specs/core/1_shard-data-chains.md

7f2e773

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>

vbuterin commented Jul 24, 2019

View reviewed changes

specs/core/1_shard-data-chains.md Show resolved Hide resolved

vbuterin added 4 commits July 24, 2019 15:21

Update specs/core/1_shard-data-chains.md

cc80342

Fixed shard header flattening

8ba1408

Update specs/core/1_shard-data-chains.md

f523ddd

Minor fixes

c7f8b11

hwwhww mentioned this pull request Jul 25, 2019

Fix the ShardBlock fields, data -> body and Bytes[PLACEHOLDER] -> BytesN[PLACEHOLDER] #1298

Closed

hwwhww reviewed Jul 25, 2019

View reviewed changes

vbuterin commented Jul 25, 2019

View reviewed changes

specs/core/1_shard-data-chains.md Outdated Show resolved Hide resolved

vbuterin and others added 5 commits July 25, 2019 14:22

Update specs/core/1_shard-data-chains.md

7df91f8

Update specs/core/1_shard-data-chains.md

e035344

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

cleanup testing and lint

dc77c06

return none if not active validators in persistent committee

ad30945

only allow active validators as shard proposer

21f4e03

djrtwo approved these changes Jul 29, 2019

View reviewed changes

vbuterin merged commit de9b4f2 into dev Jul 29, 2019

djrtwo mentioned this pull request Jul 29, 2019

Alternative crosslink data construction, take 1 #1278

Closed

djrtwo deleted the vitalik88 branch May 20, 2020 23:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attestation changes + persistent committee changes #1294

Attestation changes + persistent committee changes #1294

vbuterin commented Jul 13, 2019 •

edited

Loading

djrtwo commented Jul 23, 2019

protolambda commented Jul 23, 2019

dankrad commented Jul 23, 2019

vbuterin commented Jul 24, 2019

djrtwo Jul 24, 2019

vbuterin Jul 24, 2019

protolambda Jul 24, 2019

hwwhww Jul 25, 2019

hwwhww Jul 25, 2019

djrtwo left a comment

Attestation changes + persistent committee changes #1294

Attestation changes + persistent committee changes #1294

Conversation

vbuterin commented Jul 13, 2019 • edited Loading

djrtwo commented Jul 23, 2019

protolambda commented Jul 23, 2019

dankrad commented Jul 23, 2019

vbuterin commented Jul 24, 2019

djrtwo Jul 24, 2019

Choose a reason for hiding this comment

vbuterin Jul 24, 2019

Choose a reason for hiding this comment

protolambda Jul 24, 2019

Choose a reason for hiding this comment

hwwhww Jul 25, 2019

Choose a reason for hiding this comment

hwwhww Jul 25, 2019

Choose a reason for hiding this comment

djrtwo left a comment

Choose a reason for hiding this comment

vbuterin commented Jul 13, 2019 •

edited

Loading