This repository was archived by the owner on Jan 16, 2024. It is now read-only.
Feedback widget - Chakra-UI refactor #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactors using Chakra-UI alert-dialog
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereum-org-fork ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
changed the title
|
#161 approved and merged, we can tackle this refactor after production release, I've added a card to the backlog https://www.notion.so/efdn/refactor-Feedback-widget-701332e814d94ff8a78ff6a6b5f0e1c1?pvs=4 |
|
Closing in favor of ethereum#11906 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
focus-trap-reactpackage previously being useduseKeyPresshook previously being useduseOnClickOutsidehook previously being usedFeedbackWidgetinsideRootLayoutCherry-picks bc400d6 from #152, implementing
useSurveyhookPreview link
https://deploy-preview-160--ethereum-org-fork.netlify.app/en/about
Related Issue
https://www.notion.so/efdn/Add-Feedback-widget-c99e6d8e04b0425ca6769c7ddf63ba7d?pvs=4
Note: Alternative approach to #161 which requires an additional package and migration of two otherwise unused hooks. Takes advantage of Chakra-UI Alert Dialog component set, and
useDisclosurehook.