This repository was archived by the owner on Jan 16, 2024. It is now read-only.
Feedback widget #161
Merged
Feedback widget #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereum-org-fork ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yarn add focus-trap-react, add associated hooks, implement in RootLayout
wackerow
force-pushed
the
feedback-widget-component
branch
from
cf9f1d4 to
6c16af5
Compare
minimalsm
reviewed
Dec 1, 2023
| @@ -20,6 +20,7 @@ | |||
| "@emotion/styled": "^11.11.0", | |||
| "@storybook/react": "^7.3.2", | |||
| "clipboard": "^2.0.11", | |||
| "focus-trap-react": "^10.2.3", | |||
There was a problem hiding this comment.
pettinarip
suggested changes
Dec 5, 2023
pettinarip
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Nice job @wackerow, looks great.
I've pushed a commit to fix the not parsed translation and some conflicts with dev.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
focus-trap-reactpackageuseKeyPresshookuseOnClickOutsidehookFeedbackWidgetcomponentFeedbackWidgetinsideRootLayoutCherry-picks bc400d6 from #152, implementing
useSurveyhookRelated Issue
https://www.notion.so/efdn/Add-Feedback-widget-c99e6d8e04b0425ca6769c7ddf63ba7d?pvs=4