-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Aria label for thumbup/down feedback widget. #11725
Labels
bug 🐛
Something isn't working
dev required
This requires developer resources
good first issue
Good item to try if you're new to contributing
Comments
github-actions
bot
added
the
needs triage 📥
This issue needs triaged before being worked on
label
Nov 27, 2023
0xMBL
changed the title
Bug report
Missing Aria label for thumbup/down feedback widget. 00
Nov 27, 2023
0xMBL
changed the title
Missing Aria label for thumbup/down feedback widget. 00
Missing Aria label for thumbup/down feedback widget.
Nov 27, 2023
This issue is stale because it has been open 45 days with no activity. |
github-actions
bot
added
the
Status: Stale
This issue is stale because it has been open 30 days with no activity.
label
Jan 12, 2024
wackerow
added
good first issue
Good item to try if you're new to contributing
dev required
This requires developer resources
and removed
Status: Stale
This issue is stale because it has been open 30 days with no activity.
needs triage 📥
This issue needs triaged before being worked on
labels
Feb 1, 2024
Yes, I believe it's still an issue (at least for me) |
@wackerow ping |
wackerow
added a commit
that referenced
this issue
Feb 12, 2024
added aria label to main feedback widget fix #11725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something isn't working
dev required
This requires developer resources
good first issue
Good item to try if you're new to contributing
Describe the bug
The Feedback widget button with thumbsup/down doesnt have aria label for screen reader. Once clicked, "Yes", "No", "Close" & is "Is this page helpful?" all have aria labels and can be read on a screen reader but the inital button doesnt.
I tested using a screen reader & ran lighthouse on the page. Screen reader just said "button" and lighthouse accesibility recommended aria-label.
To reproduce
Expected behavior
I'd expect the button to be labelled "Feedback" to help with accessibility.
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
No response
Would you like to work on this issue?
The text was updated successfully, but these errors were encountered: