added aria label to main feedback widget fix #11725 #11731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy the use of the button. Also added to en common.json file. Text subject to change if necessary.
0xMBL
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
❌ Deploy Preview for ethereumorg failed.
|
0xMBL
changed the title
github-actions
bot
added
the
translation 🌍
|
Hey @0xMBL! Just updated this branch with the latest from Are we sure adding this one aria-label to the "dot" button will do what we need here? Or do we also need labels on the yes/no answer choices? Otherwise this looks good! |
|
Actually, just re-read the original issue post and sounds like the others were working appropriately for you. Will pull this in, thanks! |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added aria label to main feedback widget for screenreaders to identify what the button is for before it is clicked as per issue #11725
Description
Added aria label to FeedBackWidget.tsx component. Aria labels were present once the button was clicked but screen reader was only referring to it as "button" before it was clicked. Also added to en common.json.
Related Issue