-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "back to top" button on pages #12194
Comments
Once designs are finished I'd be happy to pick this up |
Would be happy to help with the design and work on the feature. |
Hey folks! Sounds like we need design first, then the dev implementation... @cypherspeare you mentioned wanting to help with design... I can assign you here, and will also assign @nloureiro to help out internally. For design contributions, it can be helpful to hop into our Discord and go to the If you're helping with design it's probably easier to just let you do the dev implementation too as you expressed interest in. Would work with Nuno on design stuff first, but then feel free to put a PR up for this when that is complete. If you'd rather let @alex1092 jump in at that point to contribute just let us know here! Otherwise @alex1092, we'll try to get you another one... Good First Issues labels are always a decent place to start =) |
Hey @cypherspeare Let's do it! I am happy to assist you on the design side. My take on this would be to try to fit a button/link on the footer so that the same behavior can be achieved on all the pages. What do you think? I'm open to other ideas. Feel free to use this issue to keep the conversation going. Are you comfortable working on Figma? If not al good, just post here your design ideas, an we can follow from it If you want to use Figma, here is the link to our latest changes on the footer and it as the design system in it. Use it or copy it if you think it's useful Thank you! I am looking forward to seeing your ideas. |
I’m easy, thanks guys… happy for you to forward any issues you have my way On 22 Mar 2024, at 4:36 pm, Nuno Loureiro ***@***.***> wrote:
Hey @cypherspeare
Let's do it! I am happy to assist you on the design side.
My take on this would be to try to fit a button/link on the footer so that the same behavior can be achieved on all the pages.
What do you think? I'm open to other ideas. Feel free to use this issue to keep the conversation going.
Are you comfortable working on Figma? If not al good, just post here your design ideas, an we can follow from it
If you want to use Figma, here is the link to our latest changes on the footer and it as the design system in it. Use it or copy it if you think it's useful
Thank you! I am looking forward to seeing your ideas.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
My idea was to go with something like this, not sure what´s on the left and what´s on the right, but overall is adding a button on the footer. any other ideas? |
Amazing work, I'm wondering if the return to top should be floating and not fixed to the footer though, this will allow users to return the top regardless of page position |
I've considered the floating, but we already have the feedback widget floating and think it's more important in terms of function than this one. The footer would be a simpler way to make it accessible on all pages and consistent. The placement of the button is still open, I did an early exploration of it but open to ideas. |
@alex1092 hello :) any update on this issue? |
Is this work ready for dev? |
Yes, follow that Figma file. let me know if you have any questions. Thank you |
Awaiting Reviews |
adds back to top button [Fixes #12194]
Is your feature request related to a problem? Please describe.
Some pages on ethereum.org are very long, and could benefit from a "back to top" button to help reset the user
Describe the solution you'd like
At the bottom of the page (or a button that floats at some point), we add a back to top button that takes the user to the top of the page.
Describe alternatives you've considered
Not having this button at all, may not be necessary as all nav is still accessible from wherever you are in the content generally.
Additional context
No response
Would you like to work on this issue?
The text was updated successfully, but these errors were encountered: