adds back to top button [Fixes #12194] #13058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex1092
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Review this one, ill close the other pr
…On Tue, 28 May 2024 at 16:34, Joshua ***@***.***> wrote:
hey @alex1092 <https://github.com/alex1092>, thanks for the PR!
is this a duplicate of #12906
<#12906>? which one
should be reviewed?
—
Reply to this email directly, view it on GitHub
<#13058 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AODRFBON7VVL2HPUCLPWCODZERFQXAVCNFSM6AAAAABIMLGCHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZUG43DKMZUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
minimalsm
added
the
needs design approval 🧑🎨
minimalsm
added
the
needs dev approval 🧑💻
nloureiro
approved these changes
May 28, 2024
corwintines
approved these changes
May 30, 2024
There was a problem hiding this comment.
Awesome, thank you @alex1092!
LGTM, I just added .idea to the .gitignore file to get rid of the .idea workspace files. We do this for .vscode files as well.
|
@all-contributors can you add @alex1092 for code |
|
I've put up a pull request to add @alex1092! 🎉 |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a back to top button to the
<Footer />component,Also refactors some of the layout based on design changes
Related Issue
[Fixes #12194]
Screenshots