Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Link component: cleanup deprecated to prop #13423

Closed
pettinarip opened this issue Jul 18, 2024 · 2 comments
Closed

Refactor Link component: cleanup deprecated to prop #13423

pettinarip opened this issue Jul 18, 2024 · 2 comments
Assignees
@jackabald
Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help low priority This has a low priority refactor ♻️ Changes which don't affect functionality

Comments

@pettinarip
Copy link
Member

Description

The to prop in the Link component is marked as deprecated.

TODO:

  • Replace all the instances where we are using to with href.
  • Remove the to prop from the Link component.
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jul 18, 2024
@pettinarip pettinarip mentioned this issue Jul 18, 2024
Merged
@pettinarip pettinarip added help wanted Extra attention is needed or someone is needed to help low priority This has a low priority refactor ♻️ Changes which don't affect functionality good first issue Good item to try if you're new to contributing dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Jul 18, 2024
@jackabald
Copy link
Contributor

Hey!

I want to take a stab at this issue. Is anyone working on this?

@pettinarip
Copy link
Member Author

@jackabald assigned to you, thanks!

@jackabald jackabald mentioned this issue Jul 19, 2024
Closed
jackabald added a commit to jackabald/ethereum-org-website that referenced this issue Jul 19, 2024
@jackabald
fix: removed deprecated 'to' (ethereum#13423)
62ae4b1
@jackabald jackabald mentioned this issue Jul 19, 2024
Merged
corwintines added a commit that referenced this issue Jul 23, 2024
@corwintines
Merge pull request #13433 from jackabald/update-to
3eaf4f2 
fix: removed deprecated 'to' and replaced with 'href' (#13423)
@corwintines corwintines mentioned this issue Jul 24, 2024
Merged
@corwintines corwintines mentioned this issue Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackabald jackabald

Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help low priority This has a low priority refactor ♻️ Changes which don't affect functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pettinarip @jackabald