fix: removed deprecated 'to' and replaced with 'href' (#13423) #13433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackabald
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content 🖋️
This commit updates the Breadcrumbs component to render the current page as a span instead of a link when the `isCurrentPage` prop is true. This change is necessary to align with the Chakra UI library's implementation, as documented in the source code. The `href` attribute will not be passed down to the child when rendering as a span.
pettinarip
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Thanks for the PR @jackabald
Noticed that the build fails due to a problem with the Breadcrumbs implementation. I'll try to fix this as soon as possible.
We should also remove the deprecated to prop from the link component now. I'll
a commit to fix this as well.
corwintines
approved these changes
Jul 23, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed all deprecated 'to' props with href props
Kept the 'to' prop for all custom components.
Related Issue
#13423