Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Consensys Staking to staking provider list #11630

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

beetrootkid
Copy link
Contributor

@beetrootkid beetrootkid commented Nov 8, 2023

Description

Added Consensys Staking to the staking-products.json
Added ConsensysStakingGlyphicon to the src files
NB: The second file I'm not sure I've done correctly but hoping for some help to verify cc @wackerow

Related Issue

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 262fe1d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6626c330ad5f1a0008857e8c
😎 Deploy Preview https://deploy-preview-11630--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 30
Accessibility: 93
Best Practices: 92
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow
Copy link
Member

Hey @beetrootkid! Apologies for delays here, but was able to circle back and get this in working order. Couple things:

  • I updated the icon to use just the icon portion of the logo from the website. This will fit our theming much better than just using the "words" ("consensys staking") logo.
  • I updated a couple field values based on the information that was provided in the original post/discussion; please double check these and let us know if you disagree.

Of note, there is a small bug on this page in the preview where all products are showing "battle tested" with the caution (yellow) icon... this is not yet in production, but is in our dev branch and a patch is up here: #12607... By the time this PR hits production the "battle tested" indicator for Consensys Staking will be green, given the launch was years ago.

@beetrootkid
Copy link
Contributor Author

@wackerow - thanks a lot for following up and fixing 🙏🏾. Looking forward to seeing this change live.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @beetrootkid

@wackerow wackerow merged commit 2bb117c into ethereum:dev Apr 22, 2024
6 of 7 checks passed
Copy link

gitpoap-bot bot commented Apr 22, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @beetrootkid for tool

Copy link
Contributor

@wackerow

I've put up a pull request to add @beetrootkid! 🎉

This was referenced Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Consensys under staking as a service
2 participants