Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: battle tested logic #12607

Merged
merged 1 commit into from
Apr 1, 2024
Merged

fix: battle tested logic #12607

merged 1 commit into from
Apr 1, 2024

Conversation

wackerow
Copy link
Member

Description

  • Fixes a bug introduced in refactor(StakingProductsCardGrid): update types, logic, and UI composition #11477 with the logic for the "battle tested" indicator on staking products.
  • That PR switches this logic to use guard statements, but returning after the first check was causing the "Caution" flag (6-12 months live) to take precedent even if the product had been around over 1 year ("Valid" flag). This flips the ordering so it will return the best possible flag, falling back to the "warning" flag.

Related Issue

Surfaced with PR #11477
Can see bug here (before merging): https://dev--ethereumorg.netlify.app/en/staking/saas/#saas-providers (Notice all products are listed with a yellow caution icon for "battle tested")

Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit d0d0056
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/660996241146330009c7353b
😎 Deploy Preview https://deploy-preview-12607--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines merged commit e5eaa91 into dev Apr 1, 2024
10 checks passed
@corwintines corwintines deleted the battle-tested-logic branch April 1, 2024 05:36
This was referenced Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants