fix(CallToAction): update and constrain prop object type shape #12015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR primarily addresses a React console warning from the
CallToAction
hero component:Trying to use the
key
prop will only result in receivingundefined
and create styling bugs when using it to render the button variant. Instead create unique propindex
to access an index value for use in the props logic.Also modifies typing related
CallToAction
so that:Button
component propsvariant
andisSecondary
are constrained to only the logic withinCallToAction
to determine their values per instanceindex
value when that is provided via render mapping.Related Issue
N/A