Deprecate /languages page #12428
Deprecate /languages page #12428
Conversation
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 12
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
public/content/community/language-resources/language-selector-menu.pngis excluded by:!**/*.png
Files selected for processing (36)
- public/_redirects (1 hunks)
- public/content/community/language-resources/index.md (1 hunks)
- public/content/contributing/translation-program/content-buckets/index.md (2 hunks)
- public/content/contributing/translation-program/index.md (1 hunks)
- public/content/translations/ca/community/language-resources/index.md (1 hunks)
- public/content/translations/de/community/language-resources/index.md (1 hunks)
- public/content/translations/de/contributing/translation-program/index.md (1 hunks)
- public/content/translations/el/community/language-resources/index.md (1 hunks)
- public/content/translations/es/community/language-resources/index.md (1 hunks)
- public/content/translations/es/contributing/translation-program/index.md (1 hunks)
- public/content/translations/fa/community/language-resources/index.md (1 hunks)
- public/content/translations/fr/community/language-resources/index.md (1 hunks)
- public/content/translations/fr/contributing/translation-program/index.md (1 hunks)
- public/content/translations/hu/community/language-resources/index.md (1 hunks)
- public/content/translations/id/community/index.md (1 hunks)
- public/content/translations/id/community/language-resources/index.md (1 hunks)
- public/content/translations/id/contributing/translation-program/index.md (1 hunks)
- public/content/translations/it/community/language-resources/index.md (1 hunks)
- public/content/translations/it/contributing/translation-program/index.md (1 hunks)
- public/content/translations/ja/community/language-resources/index.md (1 hunks)
- public/content/translations/ja/contributing/translation-program/index.md (1 hunks)
- public/content/translations/nl/community/language-resources/index.md (1 hunks)
- public/content/translations/pl/community/language-resources/index.md (1 hunks)
- public/content/translations/pt-br/community/language-resources/index.md (1 hunks)
- public/content/translations/pt-br/contributing/translation-program/index.md (1 hunks)
- public/content/translations/ro/community/language-resources/index.md (1 hunks)
- public/content/translations/ru/community/language-resources/index.md (1 hunks)
- public/content/translations/sw/community/language-resources/index.md (1 hunks)
- public/content/translations/tr/community/language-resources/index.md (1 hunks)
- public/content/translations/tr/contributing/translation-program/index.md (1 hunks)
- public/content/translations/uk/community/language-resources/index.md (1 hunks)
- public/content/translations/zh-tw/community/language-resources/index.md (1 hunks)
- public/content/translations/zh/community/language-resources/index.md (1 hunks)
- public/content/translations/zh/contributing/translation-program/index.md (1 hunks)
- src/components/Footer.tsx (1 hunks)
- src/components/Morpher.tsx (2 hunks)
Files not reviewed due to errors (1)
- (no review received)
Additional comments: 47
public/content/translations/zh/contributing/translation-program/index.md (1)
- 40-40: The removal of hyperlinks from the number of translators and languages is consistent with the PR's objective to streamline the presentation of language support. This change simplifies the information presentation and removes potentially outdated or unnecessary links.
src/components/Morpher.tsx (1)
- 121-124: The replacement of the
BaseLinkcomponent with theButtoncomponent and the adjustment of theonClickbehavior to trigger a language picker align with the PR's objective to enhance the language selection process. This change makes the language selection more intuitive and accessible.public/content/translations/ja/contributing/translation-program/index.md (1)
- 40-40: The removal of hyperlinks from the language count is consistent with the PR's objective to streamline the presentation of language support. This change simplifies the information presentation and removes potentially outdated or unnecessary links.
public/_redirects (1)
- 175-175: The addition of a new redirect rule for
/languagesto/:splat/aligns with the PR's objective to deprecate the dedicated/languagespage. This change ensures users are redirected to a more universal solution for language selection.public/content/translations/tr/contributing/translation-program/index.md (1)
- 40-40: The update to the presentation of the number of languages with live sites in the Ethereum.org Translation Program progress section is clear and aligns with the PR objectives. However, it's essential to ensure that this information is kept up-to-date as the number of languages and sites may change over time. Regular updates will maintain the accuracy and relevance of this information for contributors and readers.
public/content/translations/pt-br/contributing/translation-program/index.md (2)
- 40-40: The change to remove hyperlink formatting from the number "54" aligns with the PR objectives to update the presentation of language statistics. This adjustment makes the information presentation more consistent with the new approach to language selection on the site.
- 37-43: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-88]
While the primary focus of this review is on the specific change mentioned, it's important to ensure the entire document is consistent and error-free. Given the static analysis hints, consider reviewing the document for potential typographical or grammatical errors. However, since these hints may include false positives or are not directly related to the code changes, they should be verified manually.
public/content/translations/it/contributing/translation-program/index.md (2)
- 40-40: The change to remove hyperlink formatting from the number "54" aligns with the PR objectives to update the presentation of language statistics. This adjustment makes the information presentation more consistent with the new approach to language selection on the site.
- 37-43: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-88]
While the primary focus of this review is on the specific change mentioned, it's important to ensure the entire document is consistent and error-free. Given the static analysis hints, consider reviewing the document for potential typographical or grammatical errors. However, since these hints may include false positives or are not directly related to the code changes, they should be verified manually.
public/content/translations/zh/community/language-resources/index.md (2)
- 21-21: The addition of the image showcasing the language selector menu is a great visual aid that aligns well with the objective of making language selection more intuitive for users.
- 19-19: The textual modification clarifying the availability of Ethereum.org translations in over 40 languages enhances the clarity and is well-aligned with the PR objectives.
public/content/translations/zh-tw/community/language-resources/index.md (2)
- 21-21: The addition of the image showcasing the language selector menu is a great visual aid that aligns well with the objective of making language selection more intuitive for users.
- 19-19: The textual modification clarifying the availability of Ethereum.org translations in over 40 languages enhances the clarity and is well-aligned with the PR objectives.
public/content/translations/de/contributing/translation-program/index.md (1)
- 40-40: The removal of the hyperlink from the text "Die Seite ist in 54 Sprachen verfügbar" simplifies the presentation and potentially reduces confusion. However, it's important to ensure that users can still easily access detailed information about the translation program's progress elsewhere on the site.
public/content/translations/es/contributing/translation-program/index.md (1)
- 40-40: The change made to the number of languages available on the site, making it plain text instead of a hyperlink, aligns with the PR's objective to update the presentation of language availability. This modification simplifies the user experience by removing unnecessary navigation options, which could potentially confuse users or lead them away from the current page. The decision to make this information static rather than interactive seems to be a strategic choice to streamline content presentation.
public/content/translations/fr/contributing/translation-program/index.md (1)
- 40-40: The update to the number of languages displayed on the site, converting it from a hyperlink to plain text, is consistent with the PR's goal of refining how language availability is presented. This change simplifies the interface by eliminating a link that might not be necessary for the user's journey, focusing instead on providing essential information directly. It's a thoughtful adjustment that enhances clarity and reduces potential distractions.
public/content/translations/ja/community/language-resources/index.md (1)
- 21-21: The addition of the image
language-selector-menu.pngenhances the visual representation of the language selection feature on the website. This aligns with the PR's objective to make language selection more intuitive and visually accessible. Ensure the image is properly localized and accessible to Japanese-speaking users.public/content/translations/id/community/index.md (1)
- 21-21: The inclusion of the
language-selector-menu.pngimage in the Indonesian community page is a positive step towards visually guiding users on how to select languages on the Ethereum.org website. This change supports the PR's goal of enhancing the language selection process. Ensure the image is properly localized and accessible to Indonesian-speaking users.public/content/translations/id/community/language-resources/index.md (1)
- 21-21: The addition of the
language-selector-menu.pngimage on the Indonesian language resources page is consistent with the PR's objectives to visually represent the language selection feature across the site. This change enhances user understanding and accessibility. Ensure the image is properly localized and accessible to Indonesian-speaking users.public/content/translations/fa/community/language-resources/index.md (2)
- 21-21: The addition of an image showcasing the language selector menu is a positive change. It enhances the visual representation of the new method for language selection on the Ethereum.org website, making it more intuitive for users. This aligns well with the PR's objective to improve the user experience for accessing Ethereum.org in multiple languages.
- 19-19: The text update from "صفحهی زبانها" to "صفحهی زبانهای ما" is consistent with the PR's objective to deprecate the dedicated
/languagespage. By removing the hyperlink and updating the text, it guides users towards the new method of language selection without directing them to a now-deprecated page. This change is clear and aligns with the overall goal of streamlining the user experience.public/content/translations/sw/community/language-resources/index.md (1)
- 21-21: The inclusion of an image showcasing the language selector menu in the Swahili translation of the Ethereum.org website's language resources page is a commendable update. It visually represents the new method for language selection, making it easier for users to understand how to access Ethereum.org in their preferred language. This change supports the PR's goal of enhancing the user experience for non-English speakers by making language selection more intuitive and accessible.
public/content/translations/ro/community/language-resources/index.md (1)
- 19-21: The addition of the image showcasing the language selector menu (
) is a positive change, enhancing the visual guidance for users on how to switch languages on the Ethereum.org website. This aligns well with the PR's objective of making language selection more intuitive and accessible. However, ensure that the image filelanguage-selector-menu.pngis correctly placed in the expected directory to avoid broken links on the website.public/content/community/language-resources/index.md (1)
- 19-21: The addition of the description and image for the language selector menu is a great way to visually guide users on how to access the translated versions of the website. However, it's important to ensure that the image path
./language-selector-menu.pngis correct and that the image is properly added to the repository. If the image is not located in the same directory as the Markdown file, the path might need to be adjusted.Verification successful
The image path
./language-selector-menu.pngin the Markdown document is correct, and the image file has been properly added to the repository in the expected location. No further action is required.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence of the image file relative to the Markdown file. fd 'language-selector-menu.png' public/content/community/language-resources/Length of output: 147
public/content/translations/tr/community/language-resources/index.md (2)
- 19-19: The addition of the image showcasing the language selector menu is a positive change, aligning with the PR's objective to guide users towards the new method of language selection. This visual aid enhances the page's instructional value by providing a clear example of how to access language options on the website.
- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-132]
Ensure all references and instructions throughout the document are updated to reflect the new language selection method. Any mention of navigating to a
/languagespage or similar should be revised to guide users towards using the language selector menu at the top of every page. This consistency is crucial for a seamless user experience and to avoid confusion.public/content/translations/uk/community/language-resources/index.md (1)
- 21-21: The addition of the image
language-selector-menu.pngis a positive change as it visually represents the new method of language selection on the Ethereum.org website. This aligns with the PR's objective to enhance the user experience by making language selection more intuitive and directly accessible. However, ensure that the image is properly optimized for web use to maintain fast loading times and that alt text is provided for accessibility reasons.public/content/translations/nl/community/language-resources/index.md (1)
- 19-21: The addition of the image showcasing the language selector menu (
) is a positive change, aligning with the PR's objective to guide users towards the new method of language selection. However, ensure that the image filelanguage-selector-menu.pnghas been added to the repository in the correct location and is accessible. This is crucial for the image to be properly displayed on the website.Verification successful
The image file
language-selector-menu.pnghas been successfully located in the repository atpublic/content/community/language-resources/language-selector-menu.png. This confirms that the image has been added to the repository, addressing the initial concern. However, it's worth noting that the image is not stored under thetranslations/nl/directory but in a more generalcommunity/language-resources/path. This is not inherently problematic, as website content management systems often handle such cases to avoid duplicating static assets across translations. The addition of the image aligns with the PR's objective, and no further issues are identified.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence of the image file in the repository fd 'language-selector-menu.png'Length of output: 102
public/content/translations/it/community/language-resources/index.md (2)
- 19-21: The addition of the image showcasing the language selector menu is a positive change, enhancing the visual representation of how users can select their preferred language on the Ethereum.org website. This aligns well with the PR's objective to make language selection more intuitive and accessible. However, ensure that the image file
language-selector-menu.pngis correctly placed in the expected directory to avoid broken links on the website.- 16-24: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The metadata at the top of the file is correctly formatted and provides essential information for the webpage, such as title, description, and language. Good job maintaining the structure and clarity in this section.
public/content/translations/pl/community/language-resources/index.md (1)
- 19-21: The addition of the image
is a positive change as it provides a visual cue for users on how to select a language on the Ethereum.org website. This aligns with the PR's objective to enhance the language selection process and make it more intuitive for users. However, ensure that the image filelanguage-selector-menu.pngis correctly placed in the same directory as this Markdown file or the appropriate path is provided to avoid broken links on the website.public/content/translations/pt-br/community/language-resources/index.md (1)
- 19-21: The addition of the language selector menu image (
language-selector-menu.png) is a positive change, enhancing the user experience by visually guiding users on how to switch languages on the Ethereum.org website. This aligns well with the PR's objective of making language selection more intuitive and accessible. However, ensure that the image is properly optimized for web use to maintain fast page load times and that it has appropriate alt text for accessibility.public/content/translations/de/community/language-resources/index.md (1)
- 21-21: The addition of the image showcasing the language selector menu (
language-selector-menu.png) is a positive change, enhancing the visual representation of the new language selection method on the Ethereum.org website. However, it would be beneficial to include a brief description or caption for the image to provide context to readers who may rely on screen readers or prefer textual explanations over visual content.Consider adding a descriptive caption or alt text for the image to improve accessibility and provide context.
public/content/translations/el/community/language-resources/index.md (1)
- 21-21: The addition of the image for the language selector menu is a positive enhancement for visual representation. Ensure the image has appropriate alt text for accessibility.
public/content/translations/ru/community/language-resources/index.md (3)
- 21-21: The addition of the image
is a positive change, enhancing the visual representation of the language selection process on the Ethereum.org website. This aligns well with the PR's objective to make language selection more intuitive and accessible. However, ensure that the image filelanguage-selector-menu.pngis correctly placed in the same directory as the markdown file or in a designated assets directory, and that it is properly optimized for web use (size, format).- 16-24: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [13-13]
The static analysis tool flagged a possible typographical error in the segment discussing online forums for Ethereum enthusiasts. Given the context and the nature of the content, this seems to be a false positive, as the text appears to be correctly written in Russian. No action is required here.
- 16-24: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [53-53]
Several segments were flagged by the static analysis tool for possible typographical errors, mostly related to the use of specific terms like "онлайн-курсы", "блокчейн-разработку", "смарт-контракты", and others. These terms are correctly used within the context of the document, which discusses various resources related to Ethereum and blockchain technology in Russian. The suggestions provided by the tool, such as "онлайн-курс" or "блокчейн", do not indicate actual errors but rather alternative forms or misspellings of the terms used. Given the technical and language-specific nature of the content, these flagged items do not require correction.
Also applies to: 74-74, 91-91, 95-95, 98-98, 107-107, 110-110, 111-111, 112-112, 113-113, 117-117, 123-123, 129-129, 130-130, 132-132
public/content/translations/es/community/language-resources/index.md (2)
- 21-21: The addition of the image
is a positive change as it provides a visual reference for users on how to select a language on the Ethereum.org website. This aligns with the PR's objective to enhance the language selection process and make it more intuitive for users. However, ensure that the image filelanguage-selector-menu.pnghas been added to the repository in the correct location and is properly optimized for web use to ensure fast loading times.- 16-24: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The document's metadata (front matter) correctly specifies the title, description, and language. This is crucial for SEO and user navigation. Ensure that all metadata is accurate and up-to-date to reflect the content of the document accurately.
public/content/translations/fr/community/language-resources/index.md (2)
- 21-21: The addition of the image showcasing the language selector menu is a great visual aid that aligns with the PR's objective of enhancing the language selection process.
- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-132]
The content update, including the addition of the language selector menu image and the assumed textual modifications to remove hyperlink redundancy, aligns well with the PR's objectives of making language selection more intuitive and accessible. It's important to ensure that all language resources listed remain up-to-date and relevant to the community's needs.
public/content/translations/id/contributing/translation-program/index.md (5)
- 14-14: The formatting of the language count has been updated to remove hyperlinks and adjust the presentation. This change improves readability and aligns with the objective of updating the formatting for a better visual representation.
- 11-17: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The abbreviation for "identification" is spelled all-uppercase as "ID" in English. However, given the context and the fact that this document is in Indonesian, where "id" is commonly used as the language code for Indonesian, this does not constitute an error.
- 11-17: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-154]
Many of the spelling mistake flags raised by the static analysis tool are false positives, primarily due to the document being in Indonesian or containing specific terms related to Ethereum.org. These do not represent actual spelling errors.
- 17-17: There's an unpaired symbol (
") in the document. It's important to ensure that all symbols are correctly paired to maintain the integrity of the Markdown formatting. However, in this context, the symbol is used within a code snippet to represent a string, which is a common practice and does not constitute an error.- 11-17: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [52-52]
The hint about repeated whitespace is likely a false positive, as Markdown formatting often involves intentional use of whitespace for readability and structure. Unless it affects the rendered output negatively, it's generally not an issue.
public/content/contributing/translation-program/content-buckets/index.md (1)
- 18-18: The addition of "Language support" to the Main navbar aligns well with the PR's objective of enhancing language selection accessibility on the Ethereum.org website. This update should make it easier for users to find and utilize the language selection feature, contributing to a more intuitive user experience.
Regarding the static analysis hint about the spelling of "navbar," it's commonly used in web development terminology as a single word. However, ensuring consistency in terminology across the documentation is important, so no change is necessary here unless there's a specific style guide for the project that suggests otherwise.
|
@coderabbitai pause |
mobile + desktop
repeat of /community/language-resources; react `community.tsx` page takes priority
|
Note Reviews PausedUse the following commands to manage reviews:
WalkthroughThe recent updates focus on improving the user experience related to language selection and presentation on Ethereum.org. Key changes include the introduction of visual cues for language selection across various language pages, enhancements to the presentation of language statistics, and adjustments in navigation elements to facilitate easier access to translation resources. These updates streamline the process of switching languages and highlight the achievements of the translation program more effectively. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 12
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
public/content/community/language-resources/language-selector-menu.pngis excluded by:!**/*.png
Files selected for processing (38)
- public/_redirects (1 hunks)
- public/content/community/language-resources/index.md (1 hunks)
- public/content/contributing/translation-program/content-buckets/index.md (2 hunks)
- public/content/contributing/translation-program/index.md (1 hunks)
- public/content/translations/ca/community/language-resources/index.md (1 hunks)
- public/content/translations/de/community/language-resources/index.md (1 hunks)
- public/content/translations/de/contributing/translation-program/index.md (1 hunks)
- public/content/translations/el/community/language-resources/index.md (1 hunks)
- public/content/translations/es/community/language-resources/index.md (1 hunks)
- public/content/translations/es/contributing/translation-program/index.md (1 hunks)
- public/content/translations/fa/community/language-resources/index.md (1 hunks)
- public/content/translations/fr/community/language-resources/index.md (1 hunks)
- public/content/translations/fr/contributing/translation-program/index.md (1 hunks)
- public/content/translations/hu/community/language-resources/index.md (1 hunks)
- public/content/translations/id/community/language-resources/index.md (1 hunks)
- public/content/translations/id/contributing/translation-program/index.md (1 hunks)
- public/content/translations/it/community/language-resources/index.md (1 hunks)
- public/content/translations/it/contributing/translation-program/index.md (1 hunks)
- public/content/translations/ja/community/language-resources/index.md (1 hunks)
- public/content/translations/ja/contributing/translation-program/index.md (1 hunks)
- public/content/translations/nl/community/language-resources/index.md (1 hunks)
- public/content/translations/pl/community/language-resources/index.md (1 hunks)
- public/content/translations/pt-br/community/language-resources/index.md (1 hunks)
- public/content/translations/pt-br/contributing/translation-program/index.md (1 hunks)
- public/content/translations/ro/community/language-resources/index.md (1 hunks)
- public/content/translations/ru/community/language-resources/index.md (1 hunks)
- public/content/translations/sw/community/language-resources/index.md (1 hunks)
- public/content/translations/tr/community/language-resources/index.md (1 hunks)
- public/content/translations/tr/contributing/translation-program/index.md (1 hunks)
- public/content/translations/uk/community/language-resources/index.md (1 hunks)
- public/content/translations/zh-tw/community/language-resources/index.md (1 hunks)
- public/content/translations/zh/community/language-resources/index.md (1 hunks)
- public/content/translations/zh/contributing/translation-program/index.md (1 hunks)
- src/components/Morpher.tsx (2 hunks)
- src/components/Nav/Mobile/HamburgerButton.tsx (2 hunks)
- src/components/Nav/Mobile/MenuFooter.tsx (2 hunks)
- src/components/Nav/index.tsx (2 hunks)
- src/lib/constants.ts (1 hunks)
Files skipped from review as they are similar to previous changes (8)
- public/_redirects
- public/content/translations/hu/community/language-resources/index.md
- public/content/translations/id/community/language-resources/index.md
- public/content/translations/ja/community/language-resources/index.md
- public/content/translations/sw/community/language-resources/index.md
- public/content/translations/zh-tw/community/language-resources/index.md
- public/content/translations/zh/community/language-resources/index.md
- src/components/Morpher.tsx
Additional comments: 71
src/components/Nav/Mobile/HamburgerButton.tsx (2)
- 5-5: The import of
HAMBURGER_BUTTON_IDfrom@/lib/constantsis correctly implemented, ensuring that the constant is available for use within the component.- 31-31: The usage of
HAMBURGER_BUTTON_IDas theidprop for theIconButtoncomponent is appropriate. This ensures a consistent and meaningful identifier for the button, which can be useful for accessibility purposes and automated testing.src/components/Nav/Mobile/MenuFooter.tsx (2)
- 15-15: The import of
MOBILE_LANGUAGE_BUTTON_NAMEfrom@/lib/constantsis correctly implemented, ensuring that the constant is available for use within theMenuFootercomponent.- 71-71: The usage of
MOBILE_LANGUAGE_BUTTON_NAMEas thenameprop for theMenuButtoncomponent within theLanguagePickeris appropriate. This ensures a consistent and meaningful identifier for the button, enhancing the component's maintainability and readability.public/content/translations/zh/contributing/translation-program/index.md (1)
- 40-40: The update to the presentation of language statistics by removing a hyperlink and adjusting the formatting of the text is consistent with the PR's objective to enhance the visual representation of translation program achievements. Ensure that this change aligns with the overall content strategy and does not impact user navigation negatively.
src/lib/constants.ts (1)
- 96-98: The addition of constants
HAMBURGER_BUTTON_ID,MOBILE_LANGUAGE_BUTTON_NAME, andDESKTOP_LANGUAGE_BUTTON_NAMEin theconstants.tsfile is well-executed. These constants provide a centralized location for managing identifiers related to UI components, which is beneficial for maintainability and consistency across the application.public/content/translations/ja/contributing/translation-program/index.md (1)
- 40-40: The update to the representation of language support in the translation program section by removing hyperlinks from the language count is consistent with the PR's objective to enhance the visual representation of translation program achievements. Ensure that this change aligns with the overall content strategy and does not impact user navigation negatively.
src/components/Nav/index.tsx (2)
- 25-25: The import of
DESKTOP_LANGUAGE_BUTTON_NAMEfrom@/lib/constantsis correctly implemented, ensuring that the constant is available for use within theNavcomponent.- 129-129: The usage of
DESKTOP_LANGUAGE_BUTTON_NAMEas thenameprop for aMenuButtoncomponent is appropriate. This ensures a consistent and meaningful identifier for the button, enhancing the component's maintainability and readability.public/content/translations/tr/contributing/translation-program/index.md (3)
- 40-40: The update to the presentation of the number of languages with live sites is noted.
This change reflects the current status of the Ethereum.org Translation Program's progress. It's important to ensure that such statistics are kept up-to-date to accurately represent the program's achievements and scope.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [31-31]
There's a potential typo or incorrect usage in the phrase "dışarıda bırakıyor." While the spelling is correct, the static analysis suggests an alternative form might be more appropriate in some contexts. However, in this context, the usage seems appropriate, and no change is necessary unless aiming for a specific dialect or formal writing style.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [80-80]
The phrase "bir şey mi var?" is correctly used in the context of asking if there's something the reader wishes to inquire about. The static analysis tool's suggestion to combine the words does not apply to Turkish grammar rules in this context.
public/content/translations/pt-br/contributing/translation-program/index.md (13)
- 40-40: The change from hyperlink formatting to plain text for the number "54" representing the languages present on the site is noted. This adjustment aligns with the PR's objective to streamline language selection and presentation on the site.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The metadata section at the beginning of the file correctly specifies the title, language, and description. Ensure that these metadata values accurately reflect the content and purpose of the page.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [7-7]
The heading "Programa de tradução" is appropriately formatted as a level 1 heading. This is consistent with markdown best practices for structuring document headings.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [9-9]
The use of an image (
) is noted. Ensure that this image is relevant to the content and that its file path is correct. Additionally, consider adding an alt text for accessibility purposes.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [13-13]
The section "Ajude-nos a traduzir" is well-structured, providing clear instructions for potential contributors. It's important to keep such sections up-to-date to encourage community participation.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [23-23]
The use of a
<ButtonLink>component to invite users to start translating is a good practice, making the call-to-action clear and accessible. Ensure that the link is functional and leads to the intended destination.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [29-29]
The section "Sobre o Programa de Tradução" effectively communicates the goals and importance of the translation program. This helps in building a global and inclusive community.
- 37-37: The "Nosso progresso até agora" section provides valuable statistics about the translation program's achievements. Regular updates to these numbers can help in showcasing the program's growth and impact.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [51-51]
The "Certificado" subsection under "Agradecimentos" outlines a nice incentive for contributors. It's crucial to ensure that the process for obtaining certificates is clear and accessible to eligible translators.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [53-53]
The mention of POAPs (Protocolo de Prova de Presença) as a form of recognition for translators is an innovative way to engage and reward the community. Confirm that the process for claiming POAPs is straightforward and communicated effectively.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [67-67]
The "Guias e recursos" section is essential for supporting translators with resources and guides. Continuously updating and expanding these resources can further enhance the translation program's effectiveness.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [82-82]
The "Envolva-se" section encourages community interaction and provides contact information. It's important to monitor these communication channels regularly to foster a responsive and supportive community environment.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [84-84]
The initiative to help other Ethereum projects start their own translation programs, as mentioned in the "Iniciando o seu próprio programa de tradução" section, demonstrates a commitment to broadening access to Ethereum content. This collaborative spirit is commendable.
public/content/translations/it/contributing/translation-program/index.md (5)
- 40-40: The change involves removing hyperlink formatting from the number of languages listed on the site. This alteration affects the visual presentation of the information without impacting the underlying data or functionality. Ensure that this change aligns with the overall design and content strategy of the website.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
Please verify the metadata section at the beginning of the file for any potential typographical errors or inaccuracies in the
title,lang, anddescriptionfields. While the static analysis tool flagged a potential issue, it's crucial to ensure these fields accurately reflect the content and language of the page.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [7-7]
Ensure that the image link
is correctly pointing to an existing image file within the project. If the image is intended to be displayed here, verify its relevance and accessibility.
- 37-43: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-88]
Please review the entire document for language correctness, including grammar, spelling, and typographical errors. While the static analysis tool flagged numerous potential issues, it's essential to ensure the Italian text accurately conveys the information about the Ethereum translation program and adheres to high standards of language quality.
- 37-43: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-88]
Confirm that the content accurately reflects the recent changes to the language selection mechanism and the presentation of language statistics on the website. Given the PR's objectives to streamline language selection and update content across the site, it's crucial that this document is consistent with those updates and provides users with clear, up-to-date information.
public/content/translations/de/contributing/translation-program/index.md (5)
- 40-40: The change involves removing a hyperlink from the text indicating the number of languages the site is available in. This modification affects the visual presentation without altering the underlying data. Ensure this change is consistent with the website's design and content strategy.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
Please verify the metadata section at the beginning of the file for any potential typographical errors or inaccuracies in the
title,lang, anddescriptionfields. While the static analysis tool flagged a potential issue, it's crucial to ensure these fields accurately reflect the content and language of the page.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [7-7]
Ensure that the image link
is correctly pointing to an existing image file within the project. If the image is intended to be displayed here, verify its relevance and accessibility.
- 37-43: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-88]
Please review the entire document for language correctness, including grammar, spelling, and typographical errors. While the static analysis tool flagged numerous potential issues, it's essential to ensure the German text accurately conveys the information about the Ethereum translation program and adheres to high standards of language quality.
- 37-43: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-88]
Confirm that the content accurately reflects the recent changes to the language selection mechanism and the presentation of language statistics on the website. Given the PR's objectives to streamline language selection and update content across the site, it's crucial that this document is consistent with those updates and provides users with clear, up-to-date information.
public/content/translations/es/contributing/translation-program/index.md (2)
- 40-40: The change to make the number of languages available on the site plain text instead of a hyperlink is consistent with the PR's objective to streamline language selection. This simplifies the presentation and avoids unnecessary redirections.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
Consider revising the metadata section to ensure accuracy and consistency. The static analysis tool flagged a potential spelling error, but it's likely a false positive. However, it's good practice to double-check metadata for correctness.
public/content/translations/fr/contributing/translation-program/index.md (2)
- 40-40: The update to display the number of languages as plain text instead of a hyperlink aligns with the PR's goal of simplifying language selection. This change makes the presentation clearer and more straightforward.
- 37-43: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The metadata section appears to be correctly formatted, but the static analysis tool suggested using a long dash. This is likely a false positive, as the YAML front matter syntax is correct. However, always ensure metadata accuracy and consistency.
public/content/translations/fa/community/language-resources/index.md (3)
- 19-21: The addition of an image for the language selector menu and the update to the text referring to the language page are in line with the PR objectives to enhance the language selection experience on the website. However, it's important to ensure that the image file
language-selector-menu.pngis correctly placed in the same directory as this markdown file for proper rendering on the website.- 16-24: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [11-11]
The static analysis tool hinted at a potential grammatical issue with an extra period (
.) at the end of a sentence. This might be a false positive due to the complexity of Farsi grammar and the use of non-Latin characters. However, it's good practice to review the sentence for any unnecessary punctuation that could affect readability.
- 16-24: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [15-15]
The static analysis tool identified a potential spelling mistake with the word "مسأله" (issue). This seems to be a false positive, as "مسأله" is the correct spelling in Farsi for "issue" or "problem." No action is needed here, but it's a good reminder to ensure that all links and references in the document are accurate and functional.
public/content/translations/ro/community/language-resources/index.md (3)
- 19-21: The addition of the language selector menu image (
language-selector-menu.png) enhances the visual representation of the new language selection mechanism. Ensure the image is correctly placed in the repository and accessible at the specified path.- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-120]
The markdown structure, including the use of headers, lists, and links, is consistent and well-organized, facilitating easy navigation and readability.
- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-120]
The textual content is clear, informative, and relevant, effectively contributing to the Ethereum community's inclusivity by providing resources in various languages.
public/content/community/language-resources/index.md (1)
- 19-19: The description of the new language selection mechanism is clear and concise. However, it might be beneficial to add a brief explanation or tooltip in the UI itself for users who might not be familiar with the concept of a language selector menu. This could further enhance accessibility and user understanding.
public/content/translations/ca/community/language-resources/index.md (1)
- 19-21: The addition of the language selector menu image (
language-selector-menu.png) is a positive change, enhancing the visual representation of the new language selection feature. However, ensure the image file has been added to the repository and is correctly placed in the expected directory to avoid broken links.public/content/translations/tr/community/language-resources/index.md (2)
- 21-21: The addition of the language selector menu image is a positive change, enhancing the visual representation and making it easier for users to understand the new language selection mechanism. This aligns well with the document's goal of providing language resources and guidance.
- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-132]
While the static analysis has flagged numerous potential spelling mistakes, it's important to recognize that these are likely false positives due to the content being in Turkish and containing technical terms. However, it might be beneficial to have a native speaker review the document for any subtle grammatical or typographical errors that could have been overlooked.
public/content/translations/uk/community/language-resources/index.md (1)
- 21-21: The addition of the image
enhances the visual representation of the language selection process on the website. This aligns well with the PR's objective of improving the user experience for language selection.public/content/translations/nl/community/language-resources/index.md (1)
- 19-21: The update to include an image of the new language selector menu (
language-selector-menu.png) is a good addition for visual guidance. However, ensure that the image filelanguage-selector-menu.pnghas been added to the repository in the correct location and is accessible. If not already done, it might be helpful to include alt text for the image for accessibility reasons.public/content/translations/it/community/language-resources/index.md (1)
- 21-21: The addition of the image
enhances the visual representation of the language selection options, making it easier for users to understand the new feature. However, ensure that the image is properly hosted and accessible at the specified path to avoid broken links on the webpage.public/content/translations/pl/community/language-resources/index.md (3)
- 16-24: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
In the metadata section, the
langattribute is correctly set toplfor Polish. However, the static analysis hinted at a typographical convention for the abbreviation "pl." which should be followed by a period when used in a sentence, but in this context, within the YAML front matter for specifying language codes, it's correctly used without a period.
- 16-24: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [15-15]
The link syntax around
[Stwórz zgłoszenie]is correctly formatted without a space between the link text and the URL, which is the expected Markdown syntax. The static analysis hint regarding the space before the parenthesis is not applicable in this context.
- 16-24: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [7-7]
The static analysis tool flagged a potential spelling error near line 7, but without specific details, it's challenging to address. Given the context, it seems to refer to general content rather than a specific typographical error. Ensure all Polish language content is proofread for spelling and grammar to maintain the quality of the translation.
Please double-check the spelling and grammar throughout the document to ensure accuracy and professionalism in the translation.
public/content/translations/pt-br/community/language-resources/index.md (3)
- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-132]
The markdown formatting, including headers, links, and the organization of language-specific sections, adheres to best practices and is well-structured. This organization enhances readability and user navigation.
- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-132]
The content provides a comprehensive list of resources for Portuguese-speaking Ethereum community members. The update, including the visual addition of the language selector menu, aligns with the objective to improve language selection accessibility on the website.
- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-132]
While static analysis tools have flagged potential spelling errors, these are likely false positives due to the content being in Portuguese. However, it's advisable to manually review the content for any actual typographical or grammatical inaccuracies to ensure clarity and professionalism.
public/content/translations/de/community/language-resources/index.md (2)
- 21-21: The addition of the image
is consistent with the PR's objective to enhance language selection mechanisms. However, it's important to ensure that the image is correctly placed within the repository and accessible at the specified path. Additionally, consider adding a brief description or caption for the image to improve accessibility and provide context to users who might not be able to view it.Verification successful
The image
language-selector-menu.pngis correctly placed within the repository and accessible at the specified path relative to the markdown file's location. The review comment regarding the addition of the image and the suggestion to ensure its correct placement and accessibility has been verified successfully.* 16-24: > 📝 **NOTE** > This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [11-11]Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence of the image file in the repository fd 'language-selector-menu.png'Length of output: 102
In the sentence "Unser Ziel ist es, Bildungsinhalte in allen Sprachen bereitzustellen und die Sprachbarrieren zu überwinden, die Menschen aus aller Welt den in Ethereum erschweren," consider adding a comma before "die Menschen" to improve readability and adhere to grammatical norms for relative clauses in German.
public/content/translations/el/community/language-resources/index.md (1)
- 21-21: The addition of the image
language-selector-menu.pngenhances the visual presentation of the language selection feature on the site. However, it's crucial to ensure that the image is properly optimized for web use to avoid slow loading times, especially for users with slower internet connections.Consider checking the image's file size and format. Using formats like WebP can significantly reduce the file size without compromising quality.
public/content/translations/ru/community/language-resources/index.md (2)
- 21-21: The addition of the image showcasing the new language selector menu is a valuable enhancement to the visual representation of language selection options. It aligns well with the PR's objective of improving the user experience for language selection on the website.
- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [13-132]
Please consider reviewing the document for potential typographical or grammatical errors as suggested by the static analysis hints. A thorough review by a native Russian speaker could ensure the accuracy and clarity of the content.
public/content/translations/es/community/language-resources/index.md (2)
- 21-21: The addition of the image
is a positive change, enhancing the user experience by providing a visual reference for the language selection options. Ensure the image is correctly uploaded to the specified path and is accessible.- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-132]
The overall structure and content of the document are well-organized, making it easy for readers to find resources in their preferred language. This contributes significantly to the goal of making Ethereum-related content accessible globally.
public/content/translations/fr/community/language-resources/index.md (2)
- 21-21: The addition of the
image is a positive change, enhancing the visual appeal and providing a clear example of the new language selection mechanism. Ensure the image file
language-selector-menu.pngis correctly placed in the same directory for proper rendering.- 16-24: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-132]
While the document provides valuable information on language resources, consider addressing the typographical and grammatical issues highlighted by the static analysis, such as potential typos, punctuation, and verb agreement. These corrections will enhance the readability and professionalism of the document. For example, replacing hyphens with appropriate punctuation where necessary and correcting any misspelled words.
public/content/translations/id/contributing/translation-program/index.md (3)
- 14-14: The use of a period as a thousands separator in "2.500+" and "2,9 juta" is inconsistent with the English-speaking convention, which uses a comma. However, this may align with the locale-specific formatting for Indonesian. Please confirm the standard practice for numerical formatting in Indonesian content to ensure consistency and clarity.
- 11-17: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [96-96]
The warning about not using machine translations is crucial for maintaining the quality of translations. However, it's important to ensure that this message is conveyed in a supportive and encouraging tone to foster a positive community environment. Consider rephrasing to emphasize the value of human contributions and the importance of quality in translations.
- 11-17: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [152-152]
The section on "Terjemahan Launchpad Penaruhan Ethereum" mentions the Launchpad allowing anyone to set up an Ethereum validator. It's important to ensure that the technical details and implications of setting up a validator are accurately conveyed and that readers are directed to comprehensive resources for further information. This helps in setting the right expectations and providing a clear path for community members interested in contributing to the network's security.
public/content/contributing/translation-program/content-buckets/index.md (1)
- 18-18: Adding "Language support" to the Main navbar aligns with the PR's objective of enhancing language accessibility on the site. This change effectively centralizes language selection, making it more intuitive for users.
| Ethereum.org jest natywnie przetłumaczone na ponad 40 języków, które można znaleźć na naszej stronie języków. | ||
|
|
||
|  |
There was a problem hiding this comment.
The addition of the image  is a significant enhancement to the page. It visually represents the new language selection mechanism, making it easier for users to understand how to switch languages on the website. Ensure the image is properly optimized for web use in terms of file size and dimensions to maintain fast page load times.
Consider verifying the image's accessibility by adding a more descriptive alt text that explains the image's content and purpose for users who rely on screen readers.
|
|
||
| ## Ресурси Ethereum.org {#ethereum-org} | ||
|
|
||
| Ethereum.org перекладено на більше ніж 40 мов, які ви можете знайти на нашій [сторінці мов](/languages). | ||
| Ethereum.org перекладено на більше ніж 40 мов, які ви можете знайти на нашій сторінці мов. | ||
|
|
||
|  | ||
|
|
||
| Якщо ви володієте кількома мовами й хочете допомогти нам охопити більше людей, ви також можете долучитися до програми перекладу [ethereum.org](/contributing/translation-program/#translation-program) і допомогти нам перекласти вебсайт. | ||
|
|
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [53-53]
Consider using the word "безплатний" instead of "безкоштовні" for consistency with standard Ukrainian language usage.
- безкоштовні онлайн-курси
+ безплатні онлайн-курси📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [107-107]
There's a minor grammatical suggestion to improve clarity in Ukrainian. When referring to "DeFi and management," it's more appropriate to use "та" instead of "і" to connect the two concepts, especially when they are not closely related.
- DeFi і управлінню
+ DeFi та управлінню|
|
||
| ## Resursele Ethereum.org {#ethereum-org} | ||
|
|
||
| Ethereum.org este tradus nativ în peste 40 de limbi pe care le puteți găsi pe [pagina noastră de limbi](/languages). | ||
| Ethereum.org este tradus nativ în peste 40 de limbi pe care le puteți găsi pe pagina noastră de limbi. | ||
|
|
||
|  | ||
|
|
||
| Dacă sunteți bilingv și doriți să ne ajutați să ajungem la mai mulți oameni, vă puteți implica de asemenea în [Programul de traducere ethereum.org](/contributing/translation-program/#translation-program) ca să ne ajutați să traducem site-ul web. | ||
|
|
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [31-31]
There seems to be a repeated word "de de" in the sentence. Consider revising it for clarity.
- inclusiv o listă de de rate de schimb,
+ inclusiv o listă de rate de schimb,|
|
||
| ## Recursos de Ethereum.org {#ethereum-org} | ||
|
|
||
| Ethereum.org se traduce por nativos a más de 40 idiomas que puede encontrar en nuestra página [idiomas](/languages). | ||
| Ethereum.org se traduce por nativos a más de 40 idiomas que puede encontrar en nuestra página idiomas. | ||
|
|
||
|  | ||
|
|
||
| Si es bilingüe y quiere ayudarnos a llegar a más personas, también puede involucrarse en [ethereum.org Translation Program](/contributing/translation-program/#translation-program) y ayudarnos a traducir el sitio web. | ||
|
|
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [53-53]
There's a minor typographical error in the phrase "cursos en linea gratis". It should be "cursos en línea gratis" to correctly include the accent on "línea".
- cursos en linea gratis acerca de criptomonedas y sus aplicaciones.
+ cursos en línea gratis acerca de criptomonedas y sus aplicaciones.|
|
||
| ## Πόροι του Ethereum.org {#ethereum-org} | ||
|
|
||
| Το Ethereum.org είναι μεταφρασμένο σε περισσότερες από 40 γλώσσες όπου μπορείτε να βρείτε στη [σελίδα γλωσσών](/languages). | ||
| Το Ethereum.org είναι μεταφρασμένο σε περισσότερες από 40 γλώσσες όπου μπορείτε να βρείτε στη σελίδα γλωσσών. | ||
|
|
||
|  | ||
|
|
||
| Εάν γνωρίζετε μια επιπλέον γλώσσα και θέλετε να βοηθήσετε περισσότερους ανθρώπους, μπορείτε να συμμετέχετε στο [πρόγραμμα μετάφρασης του ethereum.org](/contributing/translation-program/#translation-program) και να βοηθήσετε στη μετάφραση του ιστοτόπου. | ||
|
|
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [9-9]
The phrase "μη αγγλόφωνους" should be corrected to "μην αγγλόφωνους" to adhere to the rule that the final -ν is retained before words starting with a vowel or one of the following consonants: κ, π, τ, γκ, μπ, ντ, τσ, τζ, ξ, ψ.
- μη αγγλόφωνους
+ μην αγγλόφωνους📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [13-13]
Similarly, "μη αγγλικούς" should be corrected to "μην αγγλικούς" for the same reason as above.
- μη αγγλικούς
+ μην αγγλικούς📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [59-59]
The phrase "μη κερδοσκοπική" should be corrected to "μην κερδοσκοπική" to adhere to the rule regarding the retention of the final -ν.
- μη κερδοσκοπική
+ μην κερδοσκοπική| ### Nuestra evolución hasta la fecha {#our-progress} | ||
|
|
||
| - [**+ 5.100** traductores](/contributing/translation-program/contributors/) | ||
| - [**54** idiomas disponibles en el sitio](/languages/) | ||
| - **54** idiomas disponibles en el sitio | ||
| - [3 millones de palabras traducidas en 2022](/contributing/translation-program/acknowledgements/) | ||
|
|
||
| <TranslationChartImage /> |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [9-9]
There's an extra space before the image link. While this doesn't affect the markdown rendering, it's good practice to maintain clean and consistent formatting in the document.
- 
+ 
public/content/translations/fr/contributing/translation-program/index.md
Show resolved
Hide resolved
| Ethereum.org é traduzido nativamente para mais de 40 idiomas que você pode encontrar em nossa [página de idiomas](/languages). | ||
| Ethereum.org é traduzido nativamente para mais de 40 idiomas que você pode encontrar em nossa página de idiomas. | ||
|
|
||
|  |
There was a problem hiding this comment.
Tip
Codebase Verification
The verification process has revealed that the image language-selector-menu.png is located at public/content/community/language-resources/language-selector-menu.png, while the markdown file is located at public/content/translations/pt-br/community/language-resources/index.md. Given these locations, the relative path used in the markdown file (./language-selector-menu.png) does not correctly reference the image's actual location. The image and the markdown file are in different directory paths, indicating a discrepancy in the provided relative path.
Analysis chain
The addition of the language selector menu image (language-selector-menu.png) enhances the user experience by providing a visual guide. Ensure the image is correctly placed in the repository and accessible at the specified path.
The image language-selector-menu.png is indeed present in the repository, located at public/content/community/language-resources/language-selector-menu.png. However, to confirm the correctness of the image path used in the markdown file (./language-selector-menu.png), it's essential to know the exact location of the markdown file within the repository. Given the structure of the path where the image is found, it's reasonable to infer that the markdown file should be located in the public/content/community/language-resources/ directory for the relative path to be correct.
To verify this, we need to check the location of the markdown file in question within the repository.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the existence of the image file in the repository
fd language-selector-menu.png
Length of output: 102
Script:
#!/bin/bash
# Find the location of the markdown file in question
fd 'index.md' 'public/content/translations/pt-br/community/language-resources'
Length of output: 148
|
@coderabbitai STOP |
|
@wackerow, I've noted your request to stop. If there's anything specific you need assistance with or further actions you'd like to take, please let me know. Actions performedReviews paused. |
|
@wackerow these keys wont be used anymore after removing
|
Not a strong opinion from my side. Not sure if having both has any organizational/process advantages on the Crowdin side (or in any other part). If not, I would prefer to merge or rename it, since |
|
Same.. not a strong opinion... The only thought I had was that many (not all) of the strings in Marked this as draft in the meantime and will get those updates in with this PR. |
github-actions
bot
added
the
translation 🌍
|
Okay, I just deprecated
Went through this list as well and removed all but two... Also ran a sort/linted the JSON files before committing the new merged |
Description
/languagespage in lieu of new language selection menu in navigation bar / mobile menu/community/language-resources/which has been updated to remove link and add a screenshot of the Language Picker component (for all languages)... these will need to be updated in Crowdin to match small updates to English copy./id/community/index.md; repeat of /community/language-resources/index.md and Reactcommunity.tsxpage has been taking priorityMorphercomponent to no longer link to/languages/but to instead trigger the opening of the desktop or mobile LanguagePicker depending on screen size/languages/to/contributing/translation-program/Preview link
Related issue
Summary by CodeRabbit
New Features
Documentation